Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: set fillvalue before applying scale/offset when exporting odim #173

Merged
merged 2 commits into from
Apr 23, 2024
Merged

FIX: set fillvalue before applying scale/offset when exporting odim #173

merged 2 commits into from
Apr 23, 2024

Conversation

kmuehlbauer
Copy link
Collaborator

@kmuehlbauer kmuehlbauer commented Apr 22, 2024 •
edited
Loading

@kmuehlbauer kmuehlbauer mentioned this pull request Apr 22, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Apr 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (8937457) to head (f4c1b39).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #173   +/-   ##
=======================================
  Coverage   91.32%   91.32%           
=======================================
  Files          21       21           
  Lines        4010     4010           
=======================================
  Hits         3662     3662           
  Misses        348      348
Flag Coverage Δ
notebooktests 80.57% <0.00%> (ø)
unittests 89.65% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmuehlbauer
Copy link
Collaborator Author

@mgrover1 If you have any idea how to test this, please let me know. Otherwise this should be good to go.

@kmuehlbauer kmuehlbauer requested a review from mgrover1 April 23, 2024 08:22
mgrover1
mgrover1 approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @kmuehlbauer 😄

@kmuehlbauer kmuehlbauer merged commit 5ed1f43 into openradar:main Apr 23, 2024
12 checks passed
@kmuehlbauer kmuehlbauer deleted the fix-odim-fillval branch April 23, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgrover1 mgrover1 mgrover1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xradar and pyart fillvalue discrepancy when working with ODIM
2 participants
@kmuehlbauer @mgrover1