Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log whole response body on error to give a chance to understand a reason #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sitano
Copy link

@sitano sitano commented Oct 8, 2015

usually response for /status? kind of requests would contain a description of why it failed

@agentzh
Copy link
Member

agentzh commented Oct 9, 2015

@sitano Thanks for the patch and I understand this is more useful. However, your change breaks the existing test suite. I'm getting these failures:

https://gist.github.com/agentzh/adf13526aa1625d7e50b

Will you update the test suite accordingly as well? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants