Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewriteDryRun should have option to show what the actual changes would be, similar to git diff #27

Closed
aegershman opened this issue Apr 1, 2021 · 2 comments
Assignees
Labels
wontfix This will not be worked on

Comments

@aegershman
Copy link
Contributor

from #25

rewriteDryRun's existing behavior only prints which files would be changed by which visitors, which isn't very useful. It should instead print what the actual changes would be, similar to what git diff would show you after running rewriteRun/rewriteFix

@okundzich
Copy link
Member

rewriteDryRun could produce a very long diff if it produces full output rather than a list of files changed. git diff paginates it, but build plugins do not. Maybe leaving existing behaviour is better.

@aegershman
Copy link
Contributor Author

@okundzich I'm okay with leaving this as-is and closing out the issue for the time being if you are.

Conceptually I feel like "dryRun" is more of a way to check "are there any changes available at all?", and those workflows would be better thought about in the context of continuous-integration + automation systems. And in that case, it'd probably be better to have those be their own workflow, and keep dryRun's existing functionality.

In any case I'm content to close this issue for the time being if you all are?

@aegershman aegershman self-assigned this Apr 14, 2021
@aegershman aegershman added the wontfix This will not be worked on label Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants