Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite:dryRun should default to showing what the actual changes would be, similar to git diff #116

Closed
aegershman opened this issue Apr 7, 2021 · 1 comment
Closed

rewrite:dryRun should default to showing what the actual changes would be, similar to git diff #116

aegershman opened this issue Apr 7, 2021 · 1 comment
Assignees
@aegershman
Labels
wontfix This will not be worked on

Comments

@aegershman
Copy link
Contributor

from #110 to keep separate

"rewrite:warn" should be renamed to "rewrite:dryrun". The existing behavior only prints which files would be changed by which visitors, which isn't very useful. It should instead print what the actual changes would be, similar to what git diff would show you after running run/fix
This was referenced Apr 7, 2021
Closed
Merged
@aegershman aegershman self-assigned this Apr 7, 2021
@sambsnyd sambsnyd changed the title rewriteDryRun should have option to show what the actual changes would be, similar to git diff rewriteDryRun should default to showing what the actual changes would be, similar to git diff Apr 8, 2021
@okundzich
Copy link
Member

openrewrite/rewrite-gradle-plugin#27 (comment) Please consider this here as well.

@aegershman aegershman changed the title rewriteDryRun should default to showing what the actual changes would be, similar to git diff rewrite:dryRun should default to showing what the actual changes would be, similar to git diff Apr 14, 2021
@aegershman aegershman added the wontfix This will not be worked on label Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aegershman aegershman

Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aegershman @okundzich