Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gradle enterprise setup #251

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

ribafish
Copy link
Contributor

What's changed?

  • Added Revved up by Develocity badge
  • Bumped Gradle Enterprise and Common Custom User Data plugins to latest versions
  • Updated remote build cache config to only push when authenticated

What's your motivation?

  • Bumped Gradle Enterprise and Common Custom User Data plugins to latest versions -> improved scans and support for gradle enterprise (server) 2023.4
  • Updated remote build cache config to only push when authenticated -> if an unauthenticated push is attempted remote build cache will get turned off for the rest of the build. This can happen (does) on forked PR builds which run in an unsecure environment.

Anything in particular you'd like reviewers to focus on?

In general, we strongly suggest to apply these fixes/updates to the rest of your projects, especially if you have a nice rewrite rule to do it for you 😄

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for helping out!

@timtebeek
Copy link
Contributor

I think we should be able to roll out this change through the platform using this recipe

type: specs.openrewrite.org/v1beta/recipe
name: org.openrewrite.UpgradeDevelocityGradlePlugins
displayName: Upgrade Develocity Gradle plugins
description: Upgrade the Develocity Gradle plugins.
recipeList:
  - org.openrewrite.gradle.plugins.UpgradePluginVersion:
      pluginIdPattern: com.gradle.enterprise
      newVersion: "3.16"
  - org.openrewrite.gradle.plugins.UpgradePluginVersion:
      pluginIdPattern: com.gradle.common-custom-user-data-gradle-plugin
      newVersion: 1.12.1

As per https://gradle.com/blog/develocity-global-implementation-best-practice-using-openrewrite-to-enable-develocity-project-integration-and-rollout-at-scale/ :)

@timtebeek timtebeek merged commit 835f4ed into openrewrite:main Dec 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants