Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Tests BasicIT is failing with message about RocksdbMavenPomCache #506

Closed
khmarbaise opened this issue Feb 12, 2023 · 3 comments · Fixed by #507
Closed

Integration Tests BasicIT is failing with message about RocksdbMavenPomCache #506

khmarbaise opened this issue Feb 12, 2023 · 3 comments · Fixed by #507
Labels
bug Something isn't working

Comments

@khmarbaise
Copy link
Contributor

I currenlty facing the issue related to the integration test BasicIT.

[INFO] Running org.openrewrite.maven.BasicIT
[ERROR] Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 15.833 s <<< FAILURE! - in org.openrewrite.maven.BasicIT
[ERROR] null_check_profile_activation{MavenExecutionResult}  Time elapsed: 5.267 s  <<< FAILURE!
java.lang.AssertionError: 

Expecting empty but was: ["Unable to initialize RocksdbMavenPomCache, falling back to InMemoryMavenPomCache"]
	at org.openrewrite.maven.BasicIT.null_check_profile_activation(BasicIT.java:36)

[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   BasicIT.null_check_profile_activation:36 
Expecting empty but was: ["Unable to initialize RocksdbMavenPomCache, falling back to InMemoryMavenPomCache"]
[INFO] 
[ERROR] Tests run: 24, Failures: 1, Errors: 0, Skipped: 1
[INFO] 
[INFO] 

The above is caused by the WARNING during the Maven build:

[INFO] Project [BasicIT#null_check_profile_activation] Resolving Poms...
[WARNING] Unable to initialize RocksdbMavenPomCache, falling back to InMemoryMavenPomCache
[INFO] Project [BasicIT#null_check_profile_activation] Parsing Source Files

Testing environment:

Apache Maven 3.9.0 (9b58d2bad23a66be161c4664ef21ce219c2c8584)
Maven home: /Users/khm/tools/maven
Java version: 17.0.6, vendor: Eclipse Adoptium, runtime: /Users/khm/.sdkman/candidates/java/17.0.6-tem
Default locale: en_DE, platform encoding: UTF-8
OS name: "mac os x", version: "12.4", arch: "aarch64", family: "mac"

From my understanding the produced warning is related to the underlying OS (in my case MacOS)...

@timtebeek timtebeek added the bug Something isn't working label Feb 12, 2023
timtebeek added a commit that referenced this issue Feb 12, 2023
@timtebeek
Copy link
Contributor

Hmm; I've tried to replicate this locally, but as I'm on Linux I'm not seeing the same issue; used Ubuntu 22.4.1 & Maven 3.9.0 on Temurin 17.0.6 to get as close as possible. I did notice @sambsnyd recently made two changes to RocksDB handling, even though he's on Windows, while the rest of the team is on Macs. openrewrite/rewrite@2311dec & openrewrite/rewrite@8f847c4 .

I'm tempted to ignore that known warning if it occurs: #507 . Even if it's something to fix, that would have to go into openrewrite/rewrite rather than fail a test in the Maven plugin.

@timtebeek timtebeek moved this to In Progress in OpenRewrite Feb 12, 2023
@khmarbaise
Copy link
Contributor Author

As far as I understood the code it was related to MacOS only. Sound like an reasonable way to solve that via #507. So I close that. Thanks for your deeper dive into it.

@github-project-automation github-project-automation bot moved this from In Progress to Done in OpenRewrite Feb 13, 2023
timtebeek added a commit that referenced this issue Feb 13, 2023
@timtebeek
Copy link
Contributor

You're welcome, thanks for reporting it here! Without a Mac or this report I would have never known.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants