Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not write to quark #517

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Do not write to quark #517

merged 2 commits into from
Mar 3, 2023

Conversation

timtebeek
Copy link
Contributor

@timtebeek timtebeek requested a review from sambsnyd March 2, 2023 12:54
@timtebeek timtebeek mentioned this pull request Mar 2, 2023
Closed
@timtebeek
Copy link
Contributor Author

Also reported in https://stackoverflow.com/questions/75630973/openrewrite-the-contents-of-a-quark-are-unknown-so-the-charset-is-unknown

@timtebeek timtebeek requested a review from kunli2 March 3, 2023 19:33
@sambsnyd sambsnyd merged commit 8cea2e3 into main Mar 3, 2023
@sambsnyd sambsnyd deleted the do_not_write_to_quark branch March 3, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sambsnyd sambsnyd Awaiting requested review from sambsnyd

@kunli2 kunli2 Awaiting requested review from kunli2

Assignees
No one assigned
Labels
None yet
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does the FindSourceFiles worked for binary file?
2 participants
@timtebeek @sambsnyd