Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use java.specification.version when no source and target version exists #594

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Use java.specification.version when no source and target version exists #594

merged 1 commit into from
Jul 7, 2023

Conversation

fabapp2
Copy link
Contributor

@fabapp2 fabapp2 commented Jul 4, 2023 •
edited
Loading

What's changed?

MavenMojoProjectParser uses java.specification.version as default for source and target version.

What's your motivation?

"Fix": #593

Checklist

  • I've added unit tests to cover boththe positive and negative cases, no dedicated tests existed before
  • I've added the license header to any new files through ./gradlew licenseFormat copied from RewriteRunMojo. Gradle not used in this Module and most classes don't have a license header.
  • I've used the IntelliJ auto-formatter on affected files, it formatted only previously existing code so I didn't commit this change
  • I've updated the documentation (if applicable)

@fabapp2 fabapp2 mentioned this pull request Jul 4, 2023
Closed
@knutwannheden knutwannheden added the enhancement New feature or request label Jul 5, 2023
@knutwannheden knutwannheden linked an issue Jul 5, 2023 that may be closed by this pull request
java.specification.version should be used when no java version for Maven source and target can be retrieved #593
Closed
@knutwannheden knutwannheden merged commit f38d156 into openrewrite:main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knutwannheden knutwannheden knutwannheden left review comments

@timtebeek timtebeek timtebeek left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

java.specification.version should be used when no java version for Maven source and target can be retrieved
3 participants
@fabapp2 @knutwannheden @timtebeek