Fix download snapshot warnings

[ammachado]

What's changed?

Fix download warnings for SNAPSHOT components

What's your motivation?

• Fix rewrite:run (warns about) failing to download SNAPSHOT parent from local repository rewrite#4508

Anything in particular you'd like reviewers to focus on?

No

Anyone you would like to review specifically?

@timtebeek

Have you considered any alternatives or workarounds?

No

Any additional context

No.

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[timtebeek]

Great start! Thanks for the various improvements throughout and the cache introduction to fix the underlying issue. Let me know once you've worked through the final todo before a last review & merge.

[timtebeek]

Great to see this @ammachado ; it was a bit of a puzzle for me correlating this with the MavenParser in openrewrite/rewrite, but I came up with a couple of questions that would be good to address I think. Curious to hear your thoughts, as you've perhaps already looked into those aspects.

I've also added a minimal test since I noticed none were using snapshot versions before. We might want to extend that with some assertions, although that might be a bit of a challenge with the testing framework used for plugins.

[timtebeek]

Looking at MavenPomDownloader I wonder if we should even include a dated snapshot version here, or always have that be null or project.version(). What made you introduce this ternary?

[timtebeek]

Thanks again @ammachado ! Great to see these cleared out.