Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
This PR adds support and test cases for running recipes on test source files located outside the standard maven test sources directory
src/test/java
for examplesrc/integration-test/java
.Important: The PR showed a bug with our current integration testing method for the Maven plugin. This causes the test cases that have been added to fail, even though manual testing of the plugin by myself and @timtebeek showed it works as desired. For this reason, the added tests have currently been disabled.
What's your motivation?
Currently, recipes that do not rely on classpath resources, e.g., rewriting a boolean expression, will still work. However, recipes that rely on classpath resources such as
FindTypes
will not work.build-helper-maven-plugin
#755Checklist