Add support for adding build and settings Gradle plugins #2597
Conversation
|
@shanman190 Just for my understanding: Why do the new recipes and visitors declare an option named While I can see how a pattern could make sense for |
|
|
||
| @Override | ||
| public String getDescription() { | ||
| return "Add a Gradle settings plugin to `build.gradle(.kts)`."; |
There was a problem hiding this comment.
Should probably read settings.gradle(.kts).
|
|
||
| @Value | ||
| @EqualsAndHashCode(callSuper = true) | ||
| public class AddSettingPlugin extends Recipe { |
There was a problem hiding this comment.
I am wondering if AddSettingsPlugin wouldn't be the more appropriate name.
|
@knutwannheden, honestly, was copy and paste for the options initially from another recipe. I updated the description, but forgot to update the parameter name itself. 😅 I've made the updates that you've mentioned and fixed the test issue with PR #2599. The visitor was actually existing, but I've updated it's parameter as it more aligns to the full pluginId and not a pattern like you suggested. |
|
Excellent! I wasn't sure if I was missing something here. |
No description provided.