Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null MavenMetaData.Snapshot#timestamp causes maven parser failures. #2598

Merged

Conversation

pway99
Copy link
Contributor

@pway99 pway99 commented Jan 4, 2023

This fix prevents a null timestamp from producing an invalid URI, resulting in MavenDownloadingExceptions and maven-parser failures.

org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.openrewrite.maven:rewrite-maven-plugin:4.39.0-SNAPSHOT:run (default-cli) on project ...: Execution default-cli of goal org.openrewrite.maven:rewrite-maven-plugin:4.39.0-SNAPSHOT:run failed: Failed to download dependencies for .../pom.xml:
</dependency>
  <!--~~(Unable to download POM. Tried repositories:
   https://...-snapshot: HTTP 404)~~>--><dependency> 
 at org.openrewrite.maven.MavenParser.parseInputs (MavenParser.java:127)
    at org.openrewrite.Parser.parse (Parser.java:41)
    at org.openrewrite.maven.MavenMojoProjectParser.parseMaven (MavenMojoProjectParser.java:309)
    at org.openrewrite.maven.MavenMojoProjectParser.listSourceFiles (MavenMojoProjectParser.java:119)
    at org.openrewrite.maven.AbstractRewriteMojo.listResults (AbstractRewriteMojo.java:250)

… a null timestamp from producing an invalid URI causing `MavenDownloadingExceptions` and maven-parser failures.
@sambsnyd sambsnyd merged commit 7745427 into openrewrite:main Jan 4, 2023
@sambsnyd
Copy link
Member

sambsnyd commented Jan 4, 2023

Thanks @pway99 !

@pway99 pway99 deleted the maven-snapsot-metadata-null-timestamp branch January 5, 2023 00:20
@sambsnyd sambsnyd added this to the 7.35.0 milestone Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants