Adding visited-file details to unexpected exceptions #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmck257
changed the title
sambsnyd
approved these changes
Jan 17, 2023
|
Thanks @nmck257 ! Nice improvement to have |
This was referenced Jan 17, 2023
sambsnyd
pushed a commit
that referenced
this pull request
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimally, these exceptions will now include the visited file, and grammar-specific visitors can add more precise info (eg for JavaVisitor I've added quick logic to specify by class/method name).
Would be neat to expand with line numbers, but, I didn't see an obvious way to get that during a visit
#2655