Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of unary operator in FinalizePrivateField #2679

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Fix handling of unary operator in FinalizePrivateField #2679

merged 1 commit into from
Jan 19, 2023

Conversation

knutwannheden
Copy link
Contributor

The recipe should distinguish between reading and modifying unary operators, as this may allow a few more fields to be made final.

@knutwannheden
Fix handling of unary operator in FinalizePrivateField
6b2fc69 
The recipe should distinguish between reading and modifying unary operators, as this may allow a few more fields to be made final.
@knutwannheden
Copy link
Contributor Author

@kunli2 I took the liberty to make one small improvement to your recipe with regards to the handling of unary operators.

@sambsnyd sambsnyd merged commit 13d0f9d into openrewrite:main Jan 19, 2023
@sambsnyd
Copy link
Member

Thanks @knutwannheden !

@kunli2
Copy link
Contributor

kunli2 commented Jan 19, 2023

Thanks @knutwannheden !
good point, I just learned that -i is a J.Unary.

@knutwannheden knutwannheden deleted the finalfield-operator branch January 19, 2023 22:03
@sambsnyd sambsnyd added this to the 7.35.0 milestone Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
OpenRewrite
Archived in project
Milestone
7.35.0
Development

Successfully merging this pull request may close these issues.
3 participants
@knutwannheden @sambsnyd @kunli2