Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for XPathMatcher #3919 #3934

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

ammachado
Copy link
Contributor

@ammachado ammachado commented Jan 18, 2024

What's changed?

Tests for the XPathMatcher enhancement mentioned on #3919.

What's your motivation?

Provide test scenarios for

Anything in particular you'd like reviewers to focus on?

Just providing disabled test cases

Anyone you would like to review specifically?

No

Have you considered any alternatives or workarounds?

No

Any additional context

No

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek timtebeek added the test provided Already replicated with a unit test, using JUnit pioneer's ExpectedToFail label Jan 18, 2024
@timtebeek
Copy link
Contributor

Would you like to see this merged separately already? Or are you planning a follow up with an implementation?

@ammachado
Copy link
Contributor Author

This can be merged now. I don't have an implementation for this yet.

@timtebeek timtebeek merged commit be38aff into openrewrite:main Jan 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test provided Already replicated with a unit test, using JUnit pioneer's ExpectedToFail
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants