Maven runtime dependency is on the compile scope #4273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rewrite-maven/src/test/java/org/openrewrite/maven/MavenParserTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Looks good to me! Great to see you come back with a swath of fixes across the board that must not have been easy to clue together. Know that it's very much appreciated, and I'll see them through. Hope that helps resolve a number of puzzling transitive dependency issues. I'll ping @sambsnyd for an async check after the merge, as he recently resurfaced from this change a few lines down, so he'd be interested to see this fix too with the context he's gained over the past week. |
This was referenced Jun 20, 2024
crankydillo
pushed a commit
to crankydillo/rewrite
that referenced
this pull request
Jul 11, 2024
* Runtime dependency becomes compile scope dependency issue fix * Polish * Polish * Polish text block in unit test Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Remove duplicate closing `</project>` tag from test --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Tim te Beek <tim@moderne.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple runtime dependency is on the compile scope in the
ResolutionResult. A simple unit test is includedIf the fix should go in
Scope.isInClasspathOf(Scope)we can try that.