feat: recipe for adding a key value pair to a json

[dpozinen]

What's changed?

Added recipe to add a new key and value to a json.

What's your motivation?

Currently, we can rename keys and change values, but can't add new entries to a json

• Fixes Json formatting/style doesn't seem to be respected when adding values/members #4246

[timtebeek]

Thanks for the work here @dpozinen ! I'll review after I come back home Sunday. Also, it seems like the automated suggestions broke compilation after being applied

> Task :rewrite-json:compileJava
/home/runner/work/rewrite/rewrite/rewrite-json/src/main/java/org/openrewrite/json/AddKeyValue.java:74: error: cannot find symbol
        JsonPathMatcher pathMatcher = new JsonPathMatcher(keyPath);
        ^
  symbol:   class JsonPathMatcher
  location: class AddKeyValue
/home/runner/work/rewrite/rewrite/rewrite-json/src/main/java/org/openrewrite/json/AddKeyValue.java:74: error: cannot find symbol
        JsonPathMatcher pathMatcher = new JsonPathMatcher(keyPath);
                                          ^
  symbol:   class JsonPathMatcher
  location: class AddKeyValue
/home/runner/work/rewrite/rewrite/rewrite-json/src/main/java/org/openrewrite/json/AddKeyValue.java:76: error: cannot find symbol
        return new JsonIsoVisitor<ExecutionContext>() {
                   ^
  symbol:   class JsonIsoVisitor
  location: class AddKeyValue
/home/runner/work/rewrite/rewrite/rewrite-json/src/main/java/org/openrewrite/json/AddKeyValue.java:78: error: method does not override or implement a method from a supertype
            @Override
            ^
/home/runner/work/rewrite/rewrite/rewrite-json/src/main/java/org/openrewrite/json/AddKeyValue.java:80: error: cannot find symbol
                obj = super.visitObject(obj, ctx);
                           ^
  symbol: method visitObject(JsonObject,ExecutionContext)
/home/runner/work/rewrite/rewrite/rewrite-json/src/main/java/org/openrewrite/json/AddKeyValue.java:82: error: cannot find symbol
                if (pathMatcher.matches(getCursor()) && objectDoesNotContainKey(obj, key)) {
                                        ^
  symbol: method getCursor()

[github-actions]

Some suggestions could not be made:

• rewrite-gradle/src/main/groovy/RewriteSettings.groovy
  • lines 31-36

[github-actions]

Some suggestions could not be made:

• rewrite-gradle/src/main/groovy/RewriteSettings.groovy
  • lines 31-36

[github-actions]

Some suggestions could not be made:

• rewrite-gradle/src/main/groovy/RewriteSettings.groovy
  • lines 31-36

[timtebeek]

Took me a little while longer to get to this one; looking quite good already. One thing I would still like to change is the formatting used when we append to existing elements. Right now that retains the newline before the comma introduced, where I think this will look better if that comma is on the same line as the line before it. Do you see an option to work that in still @dpozinen ?

[github-actions]

Some suggestions could not be made:

• rewrite-gradle/src/main/groovy/RewriteSettings.groovy
  • lines 31-36

[timtebeek]

I only just now see you had logged an issue along those exact lines; thanks again! It's not always easy to keep up. :)

• Json formatting/style doesn't seem to be respected when adding values/members #4246

[dpozinen]

I only just now see you had logged an issue along those exact lines; thanks again! It's not always easy to keep up. :)

• Json formatting/style doesn't seem to be respected when adding values/members #4246

Hi, yeah, I'm not entirely sure where to start with this issue, do I need to create a new style? I'll see when I have the time to get more in depth into how rewrite writes the LST, because the comma isn't part of spacing/padding of the element and is added somewhere internally

I also see you made some changes to the logic namely here. Not sure why when appending (prepend == false) to a non empty json (jsonIsEmpty == false) we are using SINGLE_SPACE instead of the space of the first element of that json?