Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support public read / auth write #3481

Conversation

matyasselmeci
Copy link
Collaborator

SOFTWARE-5727; even if a namespace has PUBLIC auth, if it also has SciTokens auth information, generate a scitokens.conf for the origin but make sure "usetokenonread" isn't set in the namespaces json.

@matyasselmeci
Copy link
Collaborator Author

This is currently deployed on topology-itb.

@matyasselmeci
Copy link
Collaborator Author

@brianhlin , @djw8605 , can you review this or suggest other reviewers?

@brianhlin
Copy link
Member

@mwestphall can you take a look at this sometime over the next week or so?

@matyasselmeci
Copy link
Collaborator Author

I'd like to have this in before I start work on https://opensciencegrid.atlassian.net/browse/SOFTWARE-5760 since they affect the same code.

@biozit
Copy link
Contributor

biozit commented Nov 17, 2023

Do you think I can help somehow?

Copy link
Collaborator

@mwestphall mwestphall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matyasselmeci matyasselmeci merged commit 2e3f600 into opensciencegrid:master Nov 20, 2023
2 checks passed
@matyasselmeci matyasselmeci deleted the pr/public-read-auth-write.SOFTWARE-5727 branch November 20, 2023 17:34
@biozit
Copy link
Contributor

biozit commented Nov 20, 2023

Can I start to test it?

@matyasselmeci
Copy link
Collaborator Author

This is deployed in production now; go ahead.

@biozit
Copy link
Contributor

biozit commented Nov 20, 2023

Looks ok, still testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants