Add "include_downed" and "include_inactive" params to the /osdf/namespaces endpoint #3659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…paces endpoint If set, the output will _not_ exclude caches/origins that are in downtime, or marked as inactive. (SOFTWARE-5826)
(writing a test for `?include_downed=1` requires making a test downtime file first)
A parsed yaml can be a list, not just a dict (it can be a scalar too, but I'll ignore that for now), but Topology.add_downtime() assumed dict, passed it to Downtime(), which raised a confusing KeyError. 1. Update the definition of ParsedYaml to indicate that it can be a list too; hopefully I'll catch things like this next time 2. If given a list, have add_downtime() add all the downtimes in the list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If set, the output will not exclude caches/origins that are in downtime, or marked as inactive.
(SOFTWARE-5826)
Along the way, I noticed that if I try to pass a downtime file (with an entire list of downtimes) to Topology.add_downtime() it will fail with a KeyError because it was expecting a dict. This was unexpected so I added checks.