Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add netcdf support #26

Closed
wants to merge 6 commits into from
Closed

Add netcdf support #26

wants to merge 6 commits into from

Conversation

lewisjared
Copy link
Collaborator

This will likely be heavily modified when we transition to the new data model, but reading writing nc files might be quicker in the mean time.

Also it allows writing output without the pyam dependency from to_csv

@lewisjared lewisjared requested a review from znicholls February 4, 2020 01:11
@lewisjared
Copy link
Collaborator Author

Still need to add a reader

@lewisjared lewisjared marked this pull request as ready for review February 4, 2020 01:11
@lewisjared
Copy link
Collaborator Author

Ignore the ready for review at the moment. The button moved as I clicked...

@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #26 into master will decrease coverage by 1.55%.
The diff coverage is 87.6%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
- Coverage   98.82%   97.27%   -1.56%     
==========================================
  Files           7        8       +1     
  Lines         767      881     +114     
  Branches      152      177      +25     
==========================================
+ Hits          758      857      +99     
- Misses          9       19      +10     
- Partials        0        5       +5
Impacted Files Coverage Δ
src/scmdata/dataframe.py 99.75% <100%> (ø) ⬆️
src/scmdata/__init__.py 100% <100%> (ø) ⬆️
src/scmdata/rw.py 85.43% <85.43%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 816a3e6...25ea44b. Read the comment docs.

@znicholls
Copy link
Collaborator

One very quick thought, iris has to/from dataframe methods and will do all the dependency handling for us so might be an easier way than using netCDF4 directly?

@lewisjared lewisjared mentioned this pull request Apr 9, 2020
5 tasks
@lewisjared lewisjared closed this Apr 9, 2020
@lewisjared lewisjared deleted the netcdf branch April 21, 2020 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants