Deangular: removes angular from notify and utils of opendashboards le…

…gacy (#5085)

* Basic working version of OSD without angular (#4982)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* deangularized notify and utils folders in the opendashboards legacy directory

Signed-off-by: Cameron Reed <chyltonreed@gmail.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Cameron Reed <chyltonreed@gmail.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Cameron Reed <chyltonreed@gmail.com>

package.json

@@ -466,4 +466,4 @@
     "node": ">=14.20.1 <19",
     "yarn": "^1.22.10"
   }
-}
+}

src/plugins/opensearch_dashboards_legacy/public/index.ts

@@ -37,4 +37,3 @@ export const plugin = (initializerContext: PluginInitializerContext) =>
 export * from './plugin';
 
 export * from './notify';
-export * from './utils';

src/plugins/opensearch_dashboards_legacy/public/notify/lib/add_fatal_error.ts

@@ -29,21 +29,15 @@
  */
 
 import { FatalErrorsSetup } from '../../../../../core/public';
-import {
-  AngularHttpError,
-  formatAngularHttpError,
-  isAngularHttpError,
-} from './format_angular_http_error';
 
+/**
+ * Adds an error to the list of fatal errors.
+ * @deprecated Use `core.fatalErrors.add` instead
+ */
 export function addFatalError(
-  fatalErrors: FatalErrorsSetup,
-  error: AngularHttpError | Error | string,
-  location?: string
-) {
-  // add support for angular http errors to newPlatformFatalErrors
-  if (isAngularHttpError(error)) {
-    error = formatAngularHttpError(error);
-  }
-
-  fatalErrors.add(error, location);
-}
+    fatalErrors: FatalErrorsSetup,
+    error: Error | string,
+    location?: string
+  ) {
+    fatalErrors.add(error, location);
+  }

src/plugins/opensearch_dashboards_legacy/public/notify/lib/index.ts

@@ -31,9 +31,3 @@
 export { formatOpenSearchMsg } from './format_opensearch_msg';
 export { formatMsg } from './format_msg';
 export { formatStack } from './format_stack';
-export {
-  isAngularHttpError,
-  formatAngularHttpError,
-  AngularHttpError,
-} from './format_angular_http_error';
-export { addFatalError } from './add_fatal_error';