Skip to content

Commit

Permalink
[Bug]Fix version conflict for plugins (#312)
Browse files Browse the repository at this point in the history
  • Loading branch information
ananzh authored Apr 24, 2021
1 parent 7717903 commit b563989
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions packages/osd-plugin-helpers/src/cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@

import Path from 'path';

import semver from 'semver';
import { RunWithCommands, createFlagError, createFailError } from '@osd/dev-utils';

import { findOpenSearchDashboardsJson } from './find_opensearch_dashboards_json';
Expand Down Expand Up @@ -94,18 +93,6 @@ export function runCli() {
plugin
);

if (semver.satisfies(opensearchDashboardsVersion, '<7.9')) {
log.error(
'These tools are not designed to work with version before 7.9, please checkout an earlier version of OpenSearch Dashboards to build your plugin'
);
process.exit(1);
}
if (semver.satisfies(opensearchDashboardsVersion, '~7.9.0')) {
log.warning(
'These tools might work with 7.9 versions, but there are known workarounds required. See https://github.com/elastic/kibana/issues/82466 for more info'
);
}

const sourceDir = plugin.directory;
const buildDir = Path.resolve(
plugin.directory,
Expand Down

0 comments on commit b563989

Please sign in to comment.