Skip to content

Commit

Permalink
fix: update icon of recent items from OUI library to enable dark mode (
Browse files Browse the repository at this point in the history
…#7508) (#7514)

* fix: use icon from library to enable dark mode



* Changeset file for PR #7508 created/updated

---------



(cherry picked from commit fc1adfa)

Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
  • Loading branch information
3 people authored Jul 26, 2024
1 parent d117eba commit e2e3f46
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 21 deletions.
2 changes: 2 additions & 0 deletions changelogs/fragments/7508.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fix:
- Update icon of recent items from OUI library to enable dark mode ([#7508](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7508))

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions src/core/public/chrome/ui/header/recent_items.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ import { WorkspaceObject } from '../../../workspace';
import { createRecentNavLink } from './nav_link';
import { HttpStart } from '../../../http';
import { ChromeNavLink } from '../../../';
// TODO: replace this icon once added to OUI https://github.com/opensearch-project/OpenSearch-Dashboards/issues/7354
import { RecentItemsIcon } from './recent_items_icon';

export interface Props {
recentlyAccessed$: Rx.Observable<ChromeRecentlyAccessedHistoryItem[]>;
Expand Down Expand Up @@ -71,7 +69,8 @@ export const RecentItems = ({
}}
data-test-subj="recentItemsSectionButton"
>
<EuiIcon type={RecentItemsIcon} size="m" />
{/* TODO: replace this icon once there is a new icon added to OUI https://github.com/opensearch-project/OpenSearch-Dashboards/issues/7354 */}
<EuiIcon type="recentlyViewedApp" size="m" />
</EuiHeaderSectionItemButton>
}
isOpen={isPopoverOpen}
Expand Down
17 changes: 0 additions & 17 deletions src/core/public/chrome/ui/header/recent_items_icon.tsx

This file was deleted.

0 comments on commit e2e3f46

Please sign in to comment.