Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] unit test schema_error.test.ts is skipped now #486

Closed
ananzh opened this issue Jun 16, 2021 · 0 comments
Closed

[Test] unit test schema_error.test.ts is skipped now #486

ananzh opened this issue Jun 16, 2021 · 0 comments
Assignees
@ananzh
Labels
test:unit v1.0.0

Comments

@ananzh
Copy link
Member

ananzh commented Jun 16, 2021 •
edited
Loading

Describe the bug

Currently, schema_error.test.ts test suite is skipped. To make a clean unit test, we want to explore and decide whether we still need to keep it as skipped.

/packages/osd-config-schema/src/errors/schema_error.test.ts
Test Suites: 1 skipped, 0 of 1 total
Tests:       1 skipped, 1 total

To Reproduce
Run:yarn test:jest {path to schema_error.test.ts}

Expected behavior
explore the skipped unit tests, check:

  • can we enable all? if yes, create a PR and close the issue

  • can we remove all? if yes, create a PR and close the issue

  • should we keep all? if yes, describe the reasons in the issue.

The final output is expected to be a cleaned unit test with all the skipped ones being checked.

OpenSearch Version
OpenSearch 1.0.0

Dashboards Version
Dashboards 1.0.0
@ananzh ananzh added bug Something isn't working test:unit v1.0.0 untriaged labels Jun 16, 2021
@ananzh ananzh self-assigned this Jun 16, 2021
This was referenced Jun 16, 2021
Closed
Merged
@ananzh ananzh removed the untriaged label Jun 18, 2021
@ananzh ananzh changed the title [BUG] unit test schema_error.test.ts is skipped now [Test] unit test schema_error.test.ts is skipped now Jun 18, 2021
@ananzh ananzh removed the bug Something isn't working label Jun 18, 2021
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Jun 18, 2021
@ananzh
[Test] Enable unit test suite: schema_error.test.ts (opensearch-proje…
c503b6e 
…ct#486)

Schema_error.test.ts is skipped due to no decision around error
handling and it fails depending on Node version in 2017. There are
some possible reasons: 1) nodejs is bumps to 8 in 2018 which
affected error handling 2) boom is used to handle http errors which
is also dependent on nodejs version. Since we forked from v7.10.2
which has a stable nodejs v10.23.1, we will enable this unit test.

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit that referenced this issue Jun 22, 2021
@ananzh
[Test] Enable unit test suite: schema_error.test.ts (#486) (#488)
1cf9a7a 
Schema_error.test.ts is skipped due to no decision around error
handling and it fails depending on Node version in 2017. There are
some possible reasons: 1) nodejs is bumps to 8 in 2018 which
affected error handling 2) boom is used to handle http errors which
is also dependent on nodejs version. Since we forked from v7.10.2
which has a stable nodejs v10.23.1, we will enable this unit test.

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh closed this as completed Jun 22, 2021
kavilla pushed a commit that referenced this issue Jun 22, 2021
@ananzh @kavilla
[Test] Enable unit test suite: schema_error.test.ts (#486) (#488)
6c873d7 
Schema_error.test.ts is skipped due to no decision around error
handling and it fails depending on Node version in 2017. There are
some possible reasons: 1) nodejs is bumps to 8 in 2018 which
affected error handling 2) boom is used to handle http errors which
is also dependent on nodejs version. Since we forked from v7.10.2
which has a stable nodejs v10.23.1, we will enable this unit test.

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
kavilla pushed a commit that referenced this issue Jun 22, 2021
@ananzh @kavilla
[Test] Enable unit test suite: schema_error.test.ts (#486) (#488)
13167f3 
Schema_error.test.ts is skipped due to no decision around error
handling and it fails depending on Node version in 2017. There are
some possible reasons: 1) nodejs is bumps to 8 in 2018 which
affected error handling 2) boom is used to handle http errors which
is also dependent on nodejs version. Since we forked from v7.10.2
which has a stable nodejs v10.23.1, we will enable this unit test.

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ananzh ananzh

Labels
test:unit v1.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ananzh