[BUG] Dashboards RC 2.10.0.6565 filter button in discover app doesn't work

[sandervandegeijn]

Describe the bug

Filter button in facetted search doesn't work. Confirmed on the latest releases of Brave and Firefox, see video.

Screen.Recording.2023-09-14.at.23.17.30.mov

Expected behavior
when clicking the + icon the filter is applied

OpenSearch Version
2.10.0.8459 Docker container

Dashboards Version
Dashboards RC 2.10.0.6565 Docker container

Plugins

Defaults + S3 repository plugin

Screenshots

If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):
Macos Ventura

Additional context
N/A

[sandervandegeijn]

Found something related. When opening a previously saved search, in the old version the filters are applied as expected. In the new version the filter are not applied. See video:

Screen.Recording.2023-09-14.at.23.34.46.mov

This is recorded in Brave v1.58.124

If you want to close the add filter window, you need to click cancel. Clicking in another part of the window doesn't close the filter window. This somewhat confused me as you can see in the video.

[sandervandegeijn]

As discussed on Slack:

Another small UI thing: clicking the close button closes the notice as expected, but if you refresh the screen it’s there again. Would have expected that it stayed away after closing it the first time.

[sandervandegeijn]

Another small thing, more of a inconsistency:

In the selected fields part, fields can be ordered. The hand cursor is intuitive there. In the available fields part fields can't be reordered, but the cursor suggests it could be. Maybe a good compromise would be that a single click opens the pane (like the
button) and holding/dragging it reorders where it can be done.

[sandervandegeijn]

Sorry, another one, this is a bug: opening a saved filter reloads the dashboards app

Screen.Recording.2023-09-15.at.00.05.48.mov

[ashwin-pc]

@ict-one-nl thanks for catching these issues. Given that we still have the legacy app available and that the 2.10 release is today, I will fix as many of these as possible before the release, but the rest may only be fixed in the next release. For the ones that arent addressed rigth away, I will move them into a separate issue for 2.11 :)

[sandervandegeijn]

Great thanks. Let me emphasize I appreciate the new look and all the work that has gone in it. Seems more responsive.

If I can help test some more let me know.

[ashwin-pc]

@ict-one-nl much appreciated :) Please feel free to open any other issue you see in the new Discover app.

Also

Another small thing, more of a inconsistency:

In the selected fields part, fields can be ordered. The hand cursor is intuitive there. In the available fields part fields can't be reordered, but the cursor suggests it could be. Maybe a good compromise would be that a single click opens the pane (like the button) and holding/dragging it reorders where it can be done.

The reason for the hand icon in the available fields is because those fields can be dragged from the list onto the selected fields in addition to the + icon. See the attached video:

Screen.Recording.2023-09-14.at.5.58.25.PM.mov

[ashwin-pc]

Sorry, another one, this is a bug: opening a saved filter reloads the dashboards app

Screen.Recording.2023-09-15.at.00.05.48.mov

Are you sure you consider this a bug? I intentionally implemented it this way to ensure that there is only one way to open saved searches. To do so without reloading the page would mean that i'd have two similar code paths to load a saved search, which if not careful can result in a drift between experiences as more changes are introduced. There are more updates that are coming to Discover soon so I wanted to make sure that we have less code paths to worry about.

[sandervandegeijn]

Hm I think I understand your implementation. From a users perspective: this screen normally only shows when first using Dashboards. So when this pops up it gave me pause: is everything okay? I understand the ultimate solution is ditching the old code path, maybe in the mean time make more explicit why this loading screen is served at the loading screen itself.

[sandervandegeijn]

Fixes for the filtering and notice not disappearing permanently: confirmed! :)

[sandervandegeijn]

@ashwin-pc Got another one on Brave:

Sorting doesn't do anything it seems. This is a saved filter that I just opened