[Discover 2.0] fixes add filter and dismissible callout #5029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
ashwin-pc
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
ashwin-pc
added
the
Skip-Changelog
ananzh
previously approved these changes
Sep 14, 2023
Codecov Report
@@ Coverage Diff @@
## main #5029 +/- ##
=======================================
Coverage 66.49% 66.50%
=======================================
Files 3403 3403
Lines 65023 65026 +3
Branches 10401 10401
=======================================
+ Hits 43235 43243 +8
+ Misses 19225 19214 -11
- Partials 2563 2569 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
abbyhu2000
previously approved these changes
Sep 14, 2023
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
kavilla
reviewed
Sep 15, 2023
| @@ -8,6 +8,7 @@ import { BehaviorSubject, Subject, merge } from 'rxjs'; | |||
| import { debounceTime } from 'rxjs/operators'; | |||
| import { i18n } from '@osd/i18n'; | |||
| import { useEffect } from 'react'; | |||
| import { cloneDeep } from 'lodash'; | |||
There was a problem hiding this comment.
probably will be apart of a future "remove lodash" epic right
similar issue: #4349
There was a problem hiding this comment.
yep, this is how the legacy app did it and i didnt want to refactor this right now
kavilla
approved these changes
Sep 15, 2023
abbyhu2000
approved these changes
Sep 15, 2023
|
@ashwin-pc I'm going to watch this bake in 2.x. Instead of waiting for main to finish and then opening and waiting another hour for 2.x, 2.10 |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
* fixes add filter and dismissible callout Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * fixes filters applying when loading a saved search Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit b9b2b79) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
* fixes add filter and dismissible callout Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * fixes filters applying when loading a saved search Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit b9b2b79) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla
pushed a commit
that referenced
this pull request
Sep 15, 2023
* fixes add filter and dismissible callout * fixes filters applying when loading a saved search --------- (cherry picked from commit b9b2b79) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla
pushed a commit
that referenced
this pull request
Sep 16, 2023
* fixes add filter and dismissible callout * fixes filters applying when loading a saved search --------- (cherry picked from commit b9b2b79) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes 4 small issues:
Issues Resolved
fixes #5027
Screenshot
Screen.Recording.2023-09-14.at.3.41.10.PM.mov
Testing the changes
Pull down the changes and open the discover app. Adding filters in the side panel should work. The dismissable callout should stay dismissed after the page refresh.
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr