Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dark Mode in Console hard to read #5233

Closed
seanneumann opened this issue Oct 5, 2023 · 5 comments · Fixed by #5327
Closed

[BUG] Dark Mode in Console hard to read #5233

seanneumann opened this issue Oct 5, 2023 · 5 comments · Fixed by #5327
Assignees
Labels
bug Something isn't working ux / ui Improvements or additions to user experience, flows, components, UI elements v2.12.0

Comments

@seanneumann
Copy link
Contributor

image image

In 2.11 (early build) dark mode, go to Dev Tools > Console. Start typing and notice the autocomplete options are dark on dark. Very hard to read. See screen cap. e.g. type "GET _cat"

@seanneumann seanneumann added bug Something isn't working untriaged labels Oct 5, 2023
@ananzh ananzh added ux / ui Improvements or additions to user experience, flows, components, UI elements and removed untriaged labels Oct 10, 2023
@ananzh
Copy link
Member

ananzh commented Oct 10, 2023

@kgcreative pls help ~

@kgcreative
Copy link
Member

@ananzh -- is there a console theme that we can pull that will do the right thing for colors?

@kgcreative
Copy link
Member

cc: @joshuarrrr -- Josh, i think you've done a minor deep dive into this?

@joshuarrrr
Copy link
Member

joshuarrrr commented Oct 12, 2023

@kgcreative The way pretty much all text editor components work is that they're wrappers around the Ace editor. Within OpenSearch Dashboards, we have this _ace_overrides SCSS file that alters the textmate ace theme to use OUI themed vars: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/core/public/styles/_ace_overrides.scss

It's just missing some additional style overrides for .ace_editor.ace_autocomplete .ace_completion-highlight, .ace_rightAlignedText, .ace_editor.ace_autocomplete .ace_line-hover.

@kgcreative
Copy link
Member

kgcreative commented Oct 13, 2023

Ok, for dark mode, let's start with:

.ace_editor.ace_autocomplete .ace_completion-highlight, let's use the same style as .ace_url
.ace_rightAlignedText, let's match the .ace_variable style
.ace_editor.ace_autocomplete .ace_line-hover, let's use the same color as .ace_active-line

Let's start with that and see how that feels?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ux / ui Improvements or additions to user experience, flows, components, UI elements v2.12.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants