Add autocommit styles to ace overrides #5327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Romero <rmerqg@amazon.com>
joshuarrrr
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
Signed-off-by: Josh Romero <rmerqg@amazon.com>
|
@kgcreative Please review the video above. I think everything looks decent, except for the mouseover hover state, which is distinct from the keyboard-selected line. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5327 +/- ##
===========================================
+ Coverage 32.93% 67.78% +34.85%
===========================================
Files 2260 3410 +1150
Lines 45769 66741 +20972
Branches 7200 10860 +3660
===========================================
+ Hits 15075 45242 +30167
+ Misses 29984 18856 -11128
- Partials 710 2643 +1933
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@joshuarrrr -- let's go ahead and make the mouse hover match keyboard focus. I think it's ok if keyboard focus + hover match each other. |
AMoo-Miki
previously approved these changes
Dec 21, 2023
kavilla
previously approved these changes
Jan 3, 2024
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
|
@AMoo-Miki you approved this. I had to handle the conflict but if the CI passes would you be willing to approve again? |
kavilla
previously approved these changes
Apr 8, 2024
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
previously approved these changes
Apr 21, 2024
github-actions
bot
added
the
Skip-Changelog
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
approved these changes
Apr 26, 2024
ashwin-pc
approved these changes
Apr 27, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 27, 2024
* Add autocommit styles to ace overrides Signed-off-by: Josh Romero <rmerqg@amazon.com> * update changelog Signed-off-by: Josh Romero <rmerqg@amazon.com> * ran yarn run lint:style --fix Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 460428c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
kavilla
pushed a commit
that referenced
this pull request
Apr 30, 2024
* Add autocommit styles to ace overrides Signed-off-by: Josh Romero <rmerqg@amazon.com> * update changelog Signed-off-by: Josh Romero <rmerqg@amazon.com> * ran yarn run lint:style --fix Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 460428c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LDrago27
pushed a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
Jun 3, 2024
* Add autocommit styles to ace overrides Signed-off-by: Josh Romero <rmerqg@amazon.com> * update changelog Signed-off-by: Josh Romero <rmerqg@amazon.com> * ran yarn run lint:style --fix Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To help with dark mode theming. Also consolidated some color definitions to reusable vars.
Issues Resolved
Fixes #5233
Changelog
Screenshot
First the existing behavior (on playground), then the fixed behavior (local)
Screen.Recording.2023-10-18.at.5.02.37.PM.mov
Testing the changes
See video above - from dev tools console, trigger autocompletion, and then see both keyboard and mouse based hover states. Also make syntax error and check the tooltip when hovering over the red X.
Check List
yarn test:jestyarn test:jest_integration