Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] CSV download has wrong MIME type #640

Closed
dpocock opened this issue Jul 10, 2021 · 4 comments · Fixed by #792
Closed

[BUG] CSV download has wrong MIME type #640

dpocock opened this issue Jul 10, 2021 · 4 comments · Fixed by #792
Labels
bug Something isn't working good first issue Good for newcomers help wanted Community development is encouraged v1.2.0
Milestone
1.2 Release

Comments

@dpocock
Copy link

dpocock commented Jul 10, 2021

Describe the bug

I tried to download a CSV

The server told me it was text/plain

The browser wanted to open it in a text editor

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

The MIME type should be text/csv

The browser should offer to open the file in a spreadsheet, not a text editor.

OpenSearch Version
opensearch-1.0.0-rc1

Dashboards Version
"version": "1.0.0-rc1",

Plugins

Please list all plugins currently enabled.

Screenshots

If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Browser and version [e.g. 22]

Additional context

Add any other context about the problem here.
@dpocock dpocock added bug Something isn't working untriaged labels Jul 10, 2021
@kavilla
Copy link
Member

kavilla commented Jul 14, 2021 •
edited
Loading

Hello @dpocock!

Would you be able to update the description to reproduce to include details like where you navigated and update the environment details? Trying to recreate and I don't get the same behavior but I could be in a completely different area of the application as you.

Thank you!

@dpocock
Copy link
Author

dpocock commented Jul 14, 2021

Please try this:

  • create a new dashboard
  • choose Data Table
  • in the Dashboard view, you see "Export: Raw Formatted"
  • click either of the links, Raw or Formatted

It will offer you a CSV file (based on the filename extension) but it says the document is plain text.

@kavilla
Copy link
Member

kavilla commented Jul 22, 2021

Ah yes I see it now. Will remove the untriaged label for now.

@kavilla kavilla added help wanted Community development is encouraged and removed untriaged labels Jul 22, 2021
@kavilla
Copy link
Member

kavilla commented Jul 28, 2021

Attached the help wanted label for now, since I am not able to get to this soon.

@tmarkley tmarkley added the good first issue Good for newcomers label Sep 8, 2021
@AMoo-Miki AMoo-Miki mentioned this issue Sep 10, 2021
Merged
5 tasks
@kavilla kavilla linked a pull request Sep 11, 2021 that will close this issue
Correct the mime-type of exported CSVs #792
Merged
5 tasks
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Sep 14, 2021
Correct the mime-type of exported CSVs
a2de1f9 
Blobs representing CSV content are generated on the browser which are then exported as downloadables. The mime-types were incorrectly set to text/plain in a few places. This commit changes the mime-type to be text/csv.

Issues Resolved
opensearch-project#640

Signed-off-by: Miki <mehranb@amazon.com>
@tmarkley tmarkley added this to the 1.2 Release milestone Sep 15, 2021
tmarkley pushed a commit that referenced this issue Sep 17, 2021
Correct the mime-type of exported CSVs (#792)
8618905 
Blobs representing CSV content are generated on the browser which are then exported as downloadables. The mime-types were incorrectly set to text/plain in a few places. This commit changes the mime-type to be text/csv.

Issues Resolved
#640

Signed-off-by: Miki <mehranb@amazon.com>
tmarkley pushed a commit to tmarkley/OpenSearch-Dashboards that referenced this issue Sep 23, 2021
Correct the mime-type of exported CSVs (opensearch-project#792)
4872617 
Blobs representing CSV content are generated on the browser which are then exported as downloadables. The mime-types were incorrectly set to text/plain in a few places. This commit changes the mime-type to be text/csv.

Issues Resolved
opensearch-project#640

Signed-off-by: Miki <mehranb@amazon.com>
@tmarkley tmarkley mentioned this issue Sep 23, 2021
Merged
1 task
tmarkley pushed a commit that referenced this issue Sep 24, 2021
Correct the mime-type of exported CSVs (#792) (#811)
70bcd1a 
Blobs representing CSV content are generated on the browser which are then exported as downloadables. The mime-types were incorrectly set to text/plain in a few places. This commit changes the mime-type to be text/csv.

Issues Resolved
#640

Signed-off-by: Miki <mehranb@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Community development is encouraged v1.2.0
Projects
None yet
Milestone
1.2 Release
Development

Successfully merging a pull request may close this issue.

Correct the mime-type of exported CSVs AMoo-Miki/OpenSearch-Dashboards
3 participants
@dpocock @tmarkley @kavilla