Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] "Experimental" banner when editing maps visualization #933

Closed
jcgraybill opened this issue Nov 12, 2021 · 2 comments · Fixed by #1848
Closed

[BUG] "Experimental" banner when editing maps visualization #933

jcgraybill opened this issue Nov 12, 2021 · 2 comments · Fixed by #1848
Assignees
@bandinib-amzn
Labels
bug Something isn't working good first issue Good for newcomers help wanted Community development is encouraged ux / ui Improvements or additions to user experience, flows, components, UI elements v2.2.0

Comments

@jcgraybill
Copy link

jcgraybill commented Nov 12, 2021 •
edited by kavilla
Loading

Describe the bug

In OpenSearch Dashboards when editing a maps visualization, a banner appears that states: "Map layer is experimental and is not subject to the support SLA of official GA features. For feedback, please create an issue in GitHub." This seems to be residual from prior to the fork, since "support SLA" and "official GA features" aren't part of the OpenSearch project lifecycle. Nix this banner.

Requirements

  • Remove the banner
  • Fix any test failures if any
  • Backport to 2.x
  • Create issues for missing items for why this was still marked as experimental
  • If it doesn't exist create it, but if there are more features marked as experimental create subsequent issues/story.
@jcgraybill jcgraybill added bug Something isn't working untriaged labels Nov 12, 2021
@jcgraybill
Copy link
Author

Clarifying, this is a Vega maps visualization. https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/vis_type_vega/public/components/experimental_map_vis_info.tsx

@tmarkley
Copy link
Contributor

Thanks for documenting this! The Controls visualization has the same message: #800

@tmarkley tmarkley added good first issue Good for newcomers help wanted Community development is encouraged ux / ui Improvements or additions to user experience, flows, components, UI elements and removed untriaged labels Nov 16, 2021
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@nickofthyme
feat: improved domain error handling (opensearch-project#933)
f480054
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 24.3.0 [skip ci]
784b572 
# [24.3.0](elastic/elastic-charts@v24.2.0...v24.3.0) (2020-12-04)

### Bug Fixes

* **highlighter:** show default highlighted radius with hidden dots ([opensearch-project#926](elastic/elastic-charts#926)) ([351c20c](elastic/elastic-charts@351c20c)), closes [opensearch-project#679](elastic/elastic-charts#679)
* **xy_chart:** improve line joins rendering ([opensearch-project#920](elastic/elastic-charts#920)) ([9a6771c](elastic/elastic-charts@9a6771c))
* point highlight based on geom position and transform ([opensearch-project#934](elastic/elastic-charts#934)) ([196ee8d](elastic/elastic-charts@196ee8d))

### Features

* allow no results component, don't require series ([opensearch-project#936](elastic/elastic-charts#936)) ([6be5c8b](elastic/elastic-charts@6be5c8b))
* improved domain error handling ([opensearch-project#933](elastic/elastic-charts#933)) ([f480054](elastic/elastic-charts@f480054))
@kavilla kavilla added the v2.2.0 label Jun 24, 2022
@bandinib-amzn bandinib-amzn self-assigned this Jun 29, 2022
@bandinib-amzn bandinib-amzn mentioned this issue Jul 5, 2022
Merged
7 tasks
bandinib-amzn added a commit to bandinib-amzn/OpenSearch-Dashboards that referenced this issue Jul 6, 2022
@bandinib-amzn
Remove banner from when editing maps visualization
d083342 
opensearch-project#933

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
kavilla pushed a commit that referenced this issue Jul 7, 2022
@bandinib-amzn
Remove banner from when editing maps visualization (#1848)
53e98a6 
Issue resolved:
#933

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Jul 7, 2022
@bandinib-amzn @github-actions
Remove banner from when editing maps visualization (#1848)
47c819c 
Issue resolved:
#933

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
(cherry picked from commit 53e98a6)
kavilla pushed a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jul 12, 2022
@bandinib-amzn @kavilla
Remove banner from when editing maps visualization (opensearch-projec…
af04540 
…t#1848)

Issue resolved:
opensearch-project#933

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
kavilla pushed a commit that referenced this issue Jul 27, 2022
@opensearch-trigger-bot @bandinib-amzn
Remove banner from when editing maps visualization (#1848) (#1856)
42bed60 
Issue resolved:
#933

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
(cherry picked from commit 53e98a6)

Co-authored-by: Bandini <63824432+bandinib-amzn@users.noreply.github.com>
CPTNB pushed a commit to CPTNB/OpenSearch-Dashboards that referenced this issue Aug 8, 2022
@bandinib-amzn @CPTNB
Remove banner from when editing maps visualization (opensearch-projec…
aec4d83 
…t#1848)

Issue resolved:
opensearch-project#933

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bandinib-amzn bandinib-amzn

Labels
bug Something isn't working good first issue Good for newcomers help wanted Community development is encouraged ux / ui Improvements or additions to user experience, flows, components, UI elements v2.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove banner when editing maps visualization bandinib-amzn/OpenSearch-Dashboards
4 participants
@tmarkley @kavilla @bandinib-amzn @jcgraybill