Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow index pattern change in visualizations #1132

Closed
wants to merge 1 commit into from
Closed

Allow index pattern change in visualizations #1132

wants to merge 1 commit into from

Conversation

AMoo-Miki
Copy link
Collaborator

@AMoo-Miki AMoo-Miki commented Jan 11, 2022 •
edited
Loading

Signed-off-by: Miki miki@amazon.com

Description

  • Introduced VisIndexPatternSelector: A plugin that offers the UX for modifying index patterns to other plugins
  • Modified the IndexPatternManagement plugin to export IndexPatternManagmentContext type
  • Modified DefaultEditorSideBar to use the new plugin to allow changing the index pattern of visualizations that use it
  • Modified SerializedVisData to include information about the index pattern (required for DefaultEditorSideBar integration)
VisIndexPatternSelector.mp4

Issues Resolved

#707

Check List

  • New functionality includes testing.
    • All tests pass
      • [-] yarn test:jest
      • [-] yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@AMoo-Miki AMoo-Miki requested a review from a team as a code owner January 11, 2022 03:58
@AMoo-Miki
Allow index pattern change in visualizations
f25ea03 
* Introduced VisIndexPatternSelector: A plugin that offers the UX for modifying index patterns to other plugins
* Modified the IndexPatternManagement plugin to export `IndexPatternManagmentContext` type
* Modified `DefaultEditorSideBar` to use the new plugin to allow changing the index pattern of visualizations that use it
* Modified `SerializedVisData` to include information about the index pattern (required for `DefaultEditorSideBar` integration)

Signed-off-by: Miki <miki@amazon.com>
tmarkley
tmarkley reviewed Jan 13, 2022
View reviewed changes
src/plugins/vis_index_pattern_selector/public/components/change_indexpattern.test.tsx
@@ -0,0 +1,79 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use the simplified header for new files:

https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/.eslintrc.js#L36-L41

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@AMoo-Miki AMoo-Miki marked this pull request as draft January 13, 2022 18:27
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@markov00 @nickofthyme
fix(partition): fix safari highlight bug on single slice (opensearch-…
729c179 
…project#1132)

fix opensearch-project#1085

Co-authored-by: Nick Partridge <nick.ryan.partridge@gmail.com>
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 29.1.0 [skip ci]
cd3f768 
# [29.1.0](elastic/elastic-charts@v29.0.0...v29.1.0) (2021-04-23)

### Bug Fixes

* **interaction:** remove unnecessary elements ([opensearch-project#1131](elastic/elastic-charts#1131)) ([dde7bdb](elastic/elastic-charts@dde7bdb)), closes [opensearch-project#1074](elastic/elastic-charts#1074)
* **partition:**  fix safari highlight bug on single slice ([opensearch-project#1132](elastic/elastic-charts#1132)) ([729c179](elastic/elastic-charts@729c179)), closes [opensearch-project#1085](elastic/elastic-charts#1085)

### Features

* **tooltip:** add stickTo option ([opensearch-project#1122](elastic/elastic-charts#1122)) ([534f2a3](elastic/elastic-charts@534f2a3)), closes [opensearch-project#921](elastic/elastic-charts#921)
@tmarkley
Copy link
Contributor

tmarkley commented Mar 3, 2022

@AMoo-Miki what's left for this PR? Is it ready for review?

@seanneumann
Copy link
Contributor

Talked to @ashwin-pc. We believe this is working, but need to follow-up with UX and PM to see if this is a feature we need.

@kgcreative
Copy link
Member

Yes -- being able to change your data source will be important. Today, the only way to do that is to manually edit the saved object. I think the main challenge would be matching settings after you switch data source. (What happens when the schema is different between index patterns)

@AMoo-Miki
Copy link
Collaborator Author

A ton of changes have been made since this PR was raised. We will need to re-test this before merging it.

@ashwin-pc
Copy link
Member

@AMoo-Miki Can we close this then and reopen it when we have time to prioritize this?

@joshuarrrr joshuarrrr mentioned this pull request Sep 28, 2022
Open
@ashwin-pc
Copy link
Member

Closing it since its been in the backlog for a year and product roadmap has changed since.

@ashwin-pc ashwin-pc closed this Mar 7, 2023
@joshuarrrr joshuarrrr mentioned this pull request Mar 27, 2023
Open
joshuali925 added a commit to joshuali925/OpenSearch-Dashboards that referenced this pull request Apr 22, 2024
@joshuali925
port VisIndexPatternSelector from opensearch-project#1132
327803c 
Signed-off-by: Joshua Li <joshuali925@gmail.com>
joshuali925 added a commit to joshuali925/OpenSearch-Dashboards that referenced this pull request May 6, 2024
@joshuali925
port VisIndexPatternSelector from opensearch-project#1132
e1a6e0f 
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmarkley tmarkley tmarkley left review comments

@ananzh ananzh Awaiting requested review from ananzh ananzh will be requested when the pull request is marked ready for review ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla will be requested when the pull request is marked ready for review kavilla is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc will be requested when the pull request is marked ready for review ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr will be requested when the pull request is marked ready for review joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 will be requested when the pull request is marked ready for review abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon will be requested when the pull request is marked ready for review zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu will be requested when the pull request is marked ready for review zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs will be requested when the pull request is marked ready for review manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX will be requested when the pull request is marked ready for review ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub will be requested when the pull request is marked ready for review Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq will be requested when the pull request is marked ready for review curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn will be requested when the pull request is marked ready for review bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe will be requested when the pull request is marked ready for review SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl will be requested when the pull request is marked ready for review ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT will be requested when the pull request is marked ready for review BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba will be requested when the pull request is marked ready for review xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi will be requested when the pull request is marked ready for review zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric will be requested when the pull request is marked ready for review mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 will be requested when the pull request is marked ready for review LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi will be requested when the pull request is marked ready for review virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli will be requested when the pull request is marked ready for review sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 will be requested when the pull request is marked ready for review joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo will be requested when the pull request is marked ready for review huyaboo is a code owner

Assignees

@AMoo-Miki AMoo-Miki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AMoo-Miki @tmarkley @seanneumann @kgcreative @ashwin-pc