-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Src/fixtures,setup node env,test utils #141
Src/fixtures,setup node env,test utils #141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment but otherwise looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a variable needs change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* [Rename] src/fixtures directory * [Rename] src/setup_node_env directory * [Rename] src/test_utils directory * [Rename] src/apm.js * [Rename] addressed review feedbacks Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
* [Rename] src/fixtures directory * [Rename] src/setup_node_env directory * [Rename] src/test_utils directory * [Rename] src/apm.js * [Rename] addressed review feedbacks Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
* [Rename] src/fixtures directory * [Rename] src/setup_node_env directory * [Rename] src/test_utils directory * [Rename] src/apm.js * [Rename] addressed review feedbacks Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
…nsearch-project#141) * fix: workspace permission entire update * refactor: rename to convertToFullWorkspacePermissions and remove read and write permission * Revert "refactor: rename to convertToFullWorkspacePermissions and remove read and write permission" This reverts commit a4b7ba7. * Revert "fix: workspace permission entire update" This reverts commit d972e13. * fix: update to client.create to override entire object * feat: add workspace version limit for object update --------- (cherry picked from commit 0bd03df) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Issue #, if available: #37
Description of changes: Src/fixtures,setup node env,test utils
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.