Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][BWC] Date range for tests incorrect params #1772

Merged
merged 1 commit into from
Jun 22, 2022
Merged

[CI][BWC] Date range for tests incorrect params #1772

merged 1 commit into from
Jun 22, 2022

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Jun 21, 2022 •
edited
Loading

Description

Incorrectly set the date range of the library. This sets the value
correctly and turns the dates into constants.

Signed-off-by: Kawika Avilla kavilla414@gmail.com

Issues Resolved

n/a

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@kavilla
[CI][BWC] Date range for tests incorrect params
8bff092 
Incorrectly set the date range of the library. This sets the value
correctly and turns the dates into consts.

Issue:
n/a

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla requested a review from a team as a code owner June 21, 2022 22:50
@joshuarrrr
Copy link
Member

What was actually incorrect with the previous inlined version? I'm not spotting the obvious bug...

ananzh
ananzh approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kavilla
Copy link
Member Author

kavilla commented Jun 22, 2022

What was actually incorrect with the previous inlined version? I'm not spotting the obvious bug...

I was passing in a single string instead of 2. So it was treated as a single interpolated string 😢

@kavilla kavilla merged commit 4703abf into opensearch-project:main Jun 22, 2022
@kavilla kavilla deleted the avillk/bwc/daterange_bug branch June 22, 2022 00:17
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 22, 2022
@kavilla @github-actions
[CI][BWC] Date range for tests incorrect params (#1772)
9bbb03f 
Incorrectly set the date range of the library. This sets the value
correctly and turns the dates into consts.

Issue:
n/a

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit 4703abf)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 22, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 22, 2022
@kavilla @github-actions
[CI][BWC] Date range for tests incorrect params (#1772)
3a6751c 
Incorrectly set the date range of the library. This sets the value
correctly and turns the dates into consts.

Issue:
n/a

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit 4703abf)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 22, 2022
Merged
@joshuarrrr
Copy link
Member

What was actually incorrect with the previous inlined version? I'm not spotting the obvious bug...

I was passing in a single string instead of 2. So it was treated as a single interpolated string 😢

Aha! Yeah, my eyes totally glazed over that - each time I saw it as 2 args 😭

joshuarrrr pushed a commit that referenced this pull request Jun 22, 2022
@opensearch-trigger-bot @kavilla
[CI][BWC] Date range for tests incorrect params (#1772) (#1773)
336a766 
Incorrectly set the date range of the library. This sets the value
correctly and turns the dates into consts.

Issue:
n/a

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit 4703abf)

Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
cliu123 pushed a commit to cliu123/OpenSearch-Dashboards that referenced this pull request Jun 30, 2022
@opensearch-trigger-bot @kavilla
[CI][BWC] Date range for tests incorrect params (opensearch-project#1772
c57babf 
) (opensearch-project#1773)

Incorrectly set the date range of the library. This sets the value
correctly and turns the dates into consts.

Issue:
n/a

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit 4703abf)

Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
cliu123 pushed a commit to cliu123/OpenSearch-Dashboards that referenced this pull request Jun 30, 2022
@opensearch-trigger-bot @kavilla
[CI][BWC] Date range for tests incorrect params (opensearch-project#1772
3355a8f 
) (opensearch-project#1773)

Incorrectly set the date range of the library. This sets the value
correctly and turns the dates into consts.

Issue:
n/a

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit 4703abf)

Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
ananzh pushed a commit that referenced this pull request Jul 29, 2022
@opensearch-trigger-bot @kavilla
[CI][BWC] Date range for tests incorrect params (#1772) (#1774)
1e63bc5 
Incorrectly set the date range of the library. This sets the value
correctly and turns the dates into consts.

Issue:
n/a

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit 4703abf)

Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
pjfitzgibbons pushed a commit to pjfitzgibbons/OpenSearch-Dashboards that referenced this pull request Oct 24, 2022
@opensearch-trigger-bot @kavilla
[CI][BWC] Date range for tests incorrect params (opensearch-project#1772
ca0de28 
) (opensearch-project#1774)

Incorrectly set the date range of the library. This sets the value
correctly and turns the dates into consts.

Issue:
n/a

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit 4703abf)

Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh approved these changes

@joshuarrrr joshuarrrr joshuarrrr approved these changes

Assignees
No one assigned
Labels
backport 2.x ci test:bwc v2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kavilla @joshuarrrr @ananzh