[Deprecation] Deprecate the Blacklist / Whitelist nomenclature

[kaddy645]

Signed-off-by: kaddy645 xdeskart@amazon.com

Description

OpenSearch repository is going to replace the terminology "blacklist / whitelist" with "denylist / allowlist".

Changes required for config files are through root renameFromRootWithoutMap method

http.compression.referrerWhitelist config (parent config is opensearch, ( Unknown configuration key(s)/ does not exists)
http.compression.referrerWhitelistConfigured config (parent config is opensearch, ( Unknown configuration key(s)/ does not exists)
http.xsrf.whitelist config (parent config is opensearch, ( Unknown configuration key(s)/ does not exists)
http.xsrf.whitelistConfigured config (parent config is opensearch, ( Unknown configuration key(s)/ does not exists)
opensearch.requestHeadersWhitelist config   --> renameFromRootWithoutMap
opensearch.requestHeadersWhitelistConfigured config   --> renameFromRootWithoutMap
server.compression.referrerWhitelist config   --> renameFromRootWithoutMap
server.xsrf.whitelist config   --> renameFromRootWithoutMap

Issues Resolved

#1319
#1544

Check List

• New functionality includes testing.
  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
• New functionality has been documented.
• Commits are signed per the DCO using --signoff

[joshuarrrr]

Nice start - I had a couple questions about whether some other config values and functions needed updates.

[kavilla]

Looks like the linter is failing.

[kavilla]

Blocking for now since the configs were updated which would be a breaking change, they should be deprecated.

[codecov-commenter]

Codecov Report

Merging #1808 (8b71d15) into main (5fb4143) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #1808      +/-   ##
==========================================
- Coverage   67.51%   67.50%   -0.01%     
==========================================
  Files        3077     3077              
  Lines       59188    59199      +11     
  Branches     9003     9011       +8     
==========================================
+ Hits        39958    39963       +5     
- Misses      17045    17049       +4     
- Partials     2185     2187       +2     

Impacted Files	Coverage Δ
src/core/server/opensearch/opensearch_config.ts	93.50% <ø> (ø)
...aps_legacy/public/map/opensearch_dashboards_map.js	25.62% <0.00%> (ø)
...line/server/series_functions/fixtures/tl_config.js	72.72% <ø> (ø)
...gins/vis_type_timeseries/common/ui_restrictions.ts	100.00% <ø> (ø)
...es/public/application/lib/check_ui_restrictions.js	76.92% <33.33%> (ø)
...arch_dashboards_react/public/markdown/markdown.tsx	87.87% <85.71%> (-4.43%)	⬇️
.../public/application/components/tutorial/content.js	100.00% <100.00%> (ø)
src/plugins/maps_legacy/public/map/map_messages.js	29.03% <100.00%> (ø)
...server/series_functions/helpers/graphite_helper.js	81.81% <100.00%> (ø)
...b/search_strategies/default_search_capabilities.js	95.23% <100.00%> (+0.79%)	⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[manasvinibs]

Blocking for now since the configs were updated which would be a breaking change, they should be deprecated.

@kaddy645 Did we address this comment as I can still see some config values being deleted? Is it intended?

[ananzh]

LGTM