Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix new issue link #1837

Merged
merged 1 commit into from
Jul 1, 2022
Merged

[Bug] Fix new issue link #1837

merged 1 commit into from
Jul 1, 2022

Conversation

CPTNB
Copy link
Contributor

@CPTNB CPTNB commented Jun 30, 2022

Fixes #1832

Signed-off-by: Brooke Green cptn@amazon.com

Description

Fixes #1832

Signed-off-by: Brooke Green cptn@amazon.com

Issues Resolved

#1832

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

Fixes opensearch-project#1832

Signed-off-by: Brooke Green <cptn@amazon.com>
@CPTNB CPTNB requested a review from a team as a code owner June 30, 2022 22:43
@kavilla kavilla added bug Something isn't working backport 2.x labels Jun 30, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1837 (9f93abe) into main (a9984f6) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1837      +/-   ##
==========================================
- Coverage   67.50%   67.50%   -0.01%     
==========================================
  Files        3074     3074              
  Lines       59127    59127              
  Branches     8988     8988              
==========================================
- Hits        39913    39911       -2     
- Misses      17030    17031       +1     
- Partials     2184     2185       +1     
Impacted Files Coverage Δ
...ic/application/models/sense_editor/sense_editor.ts 64.00% <0.00%> (-0.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9984f6...9f93abe. Read the comment docs.

Copy link
Member

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@joshuarrrr
Copy link
Member

Should this be backported to 1.x as well?

@joshuarrrr joshuarrrr merged commit b7965f9 into opensearch-project:main Jul 1, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 1, 2022
Fixes #1832

Signed-off-by: Brooke Green <cptn@amazon.com>
(cherry picked from commit b7965f9)
CPTNB added a commit that referenced this pull request Jul 18, 2022
Fixes #1832

Signed-off-by: Brooke Green <cptn@amazon.com>
(cherry picked from commit b7965f9)
Signed-off-by: Brooke Green <cptn@amazon.com>
joshuarrrr pushed a commit that referenced this pull request Jul 28, 2022
* [Bug] Fix new issue link (#1837)

Fixes #1832

Signed-off-by: Brooke Green <cptn@amazon.com>
(cherry picked from commit b7965f9)
Signed-off-by: Brooke Green <cptn@amazon.com>

* [Tests] update tests to reflect max zoom level for maps (#1823) (#1826)

Maps zoom level were updated to be 14 as noted here:
opensearch-project/maps#4 (comment)

Issue:
n/a

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit e7362f9)

Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Brooke Green <cptn@amazon.com>

Co-authored-by: Brooke <97559014+CPTNB@users.noreply.github.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
@ananzh ananzh added the v2.2.0 label Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x bug Something isn't working v2.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] "TSVB visualization contains outdated configuration" error points to wrong dashboards github repository
6 participants