Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lint] manually fix lint errors #184

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Mar 18, 2021

Signed-off-by: Kawika Avilla kavilla414@gmail.com

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@odfe-release-bot
Copy link

✅   DCO Check Passed

@kavilla kavilla closed this Mar 18, 2021
@kavilla kavilla deleted the manual-fix-lint branch March 18, 2021 07:55
@kavilla kavilla restored the manual-fix-lint branch March 18, 2021 08:03
@kavilla kavilla reopened this Mar 18, 2021
@odfe-release-bot
Copy link

✅   DCO Check Passed

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@kavilla kavilla merged commit a8ed664 into opensearch-project:dashboards Mar 18, 2021
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
mihirsoni pushed a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla deleted the manual-fix-lint branch March 22, 2021 19:28
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Oct 9, 2023
* add more unit test cases

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* throw error with all errorObjects

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants