Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Updates Code of Conduct #1964

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

bandinib-amzn
Copy link
Member

@bandinib-amzn bandinib-amzn commented Jul 27, 2022

Description

Updates code of conduct.

Issues Resolved

#1897

Signed-off-by: Bandini Bhopi bandinib@amazon.com

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

Issue resolved:
opensearch-project#1897

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
@bandinib-amzn bandinib-amzn self-assigned this Jul 27, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1964 (1415a4c) into main (30255ab) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1964   +/-   ##
=======================================
  Coverage   67.49%   67.49%           
=======================================
  Files        3076     3076           
  Lines       59144    59144           
  Branches     8989     8989           
=======================================
  Hits        39919    39919           
  Misses      17041    17041           
  Partials     2184     2184           

Help us with your feedback. Take ten seconds to tell us how you rate us.

@bandinib-amzn bandinib-amzn requested a review from AMoo-Miki July 27, 2022 17:11
@bandinib-amzn bandinib-amzn marked this pull request as ready for review July 27, 2022 17:12
@bandinib-amzn bandinib-amzn requested a review from a team as a code owner July 27, 2022 17:12
Copy link
Member

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some formatting suggestions, but otherwise looks good!

## Code of Conduct
This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - should be blank line after headers

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in sync with all other repos OpenSearch has.

## Code of Conduct
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Code of Conduct
# Code of Conduct

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in sync with all other repos OpenSearch has. Hence, ## is correct.

@bandinib-amzn bandinib-amzn merged commit 54c2cdc into opensearch-project:main Jul 28, 2022
@bandinib-amzn bandinib-amzn deleted the Issue-1897 branch July 28, 2022 19:39
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 29, 2022
Issue resolved:
#1897

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
(cherry picked from commit 54c2cdc)
@kavilla kavilla added the docs Improvements or additions to documentation label Aug 1, 2022
kavilla pushed a commit that referenced this pull request Aug 1, 2022
Issue resolved:
#1897

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
(cherry picked from commit 54c2cdc)

Co-authored-by: Bandini <63824432+bandinib-amzn@users.noreply.github.com>
noCharger pushed a commit that referenced this pull request Aug 3, 2022
Issue resolved:
#1897

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
CPTNB pushed a commit to CPTNB/OpenSearch-Dashboards that referenced this pull request Aug 8, 2022
Issue resolved:
opensearch-project#1897

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x docs Improvements or additions to documentation v2.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants