Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PURIFY] Removes License from RPM builds #213

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

mihirsoni
Copy link
Contributor

Signed-off-by: Mihir Soni mihirsoni.123@gmail.com

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
boktorbb
boktorbb previously approved these changes Mar 22, 2021
kavilla
kavilla previously approved these changes Mar 22, 2021
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This logic is the stuff I need to cleanup still from my "first" task. Also looking at this reminds of some logic that we forgot where the unit test should fell where it checks for the first char .

@odfe-release-bot
Copy link

✅   DCO Check Passed

@mihirsoni
Copy link
Contributor Author

LGTM! This logic is the stuff I need to cleanup still from my "first" task. Also looking at this reminds of some logic that we forgot where the unit test should fell where it checks for the first char .

Yup that will first thing we will need to fix mainly just vend out oss distribution and nothigng else. This PR just remove the reference of x-pack.

@odfe-release-bot
Copy link

❌   DCO Check Failed
Run ./dev-tools/signoff-check.sh remotes/origin/main 74e5ae3fe41d98c495f5c994bece5ad6939d9a2e to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
@mihirsoni mihirsoni dismissed stale reviews from kavilla and boktorbb via 949bb78 March 22, 2021 16:26
@odfe-release-bot
Copy link

✅   DCO Check Passed

@mihirsoni mihirsoni requested a review from ananzh March 22, 2021 16:31
@boktorbb boktorbb self-requested a review March 22, 2021 16:42
@mihirsoni mihirsoni merged commit 4670f18 into opensearch-project:main Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants