Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] Change timeline icon #2162

Merged
merged 1 commit into from
Sep 6, 2022
Merged

[UX] Change timeline icon #2162

merged 1 commit into from
Sep 6, 2022

Conversation

bandinib-amzn
Copy link
Member

Signed-off-by: Bandini Bhopi bandinib@amazon.com

Description

Changed Timeline Viz icon on the visualization type selection screen.

SC

Screen Shot 2022-08-17 at 1 57 06 PM

Issues Resolved

#2155

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@bandinib-amzn
Change timeline icon
09c192c 
Issue Resolved:
opensearch-project#2155

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
@bandinib-amzn bandinib-amzn changed the title [UX} Change timeline icon [UX] Change timeline icon Aug 17, 2022
@bandinib-amzn bandinib-amzn self-assigned this Aug 17, 2022
@bandinib-amzn bandinib-amzn marked this pull request as ready for review August 17, 2022 23:02
@bandinib-amzn bandinib-amzn requested a review from a team as a code owner August 17, 2022 23:02
@seraphjiang seraphjiang added the ux / ui Improvements or additions to user experience, flows, components, UI elements label Aug 18, 2022
KrooshalUX
KrooshalUX reviewed Aug 18, 2022
View reviewed changes
Copy link

@KrooshalUX KrooshalUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the screenshot provided,this looks great. Thanks!

kgcreative
kgcreative reviewed Aug 18, 2022
View reviewed changes
Copy link
Member

@kgcreative kgcreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ashwin-pc
Copy link
Member

dont we need to update the version of OUI used?

@bandinib-amzn
Copy link
Member Author

dont we need to update the version of OUI used?

No. This icon is from OUI 1.0.0. We used existing timeline icon. So no need to update OUI version for this change.

@joshuarrrr joshuarrrr merged commit 763b7f0 into opensearch-project:main Sep 6, 2022
@kavilla
Copy link
Member

kavilla commented Sep 6, 2022

Just wanted to verify this: #658 and it worked fine. I think we can backport this change

opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 6, 2022
@bandinib-amzn @github-actions
Change timeline icon (#2162)
5d3fb10 
Issue Resolved:
#2155

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
(cherry picked from commit 763b7f0)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 6, 2022
Merged
joshuarrrr pushed a commit that referenced this pull request Sep 6, 2022
@bandinib-amzn @joshuarrrr
Change timeline icon (#2162)
3a6c3c1 
Issue Resolved:
#2155

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
(cherry picked from commit 763b7f0)
ananzh pushed a commit that referenced this pull request Sep 7, 2022
@opensearch-trigger-bot @bandinib-amzn @joshuarrrr
Change timeline icon (#2162) (#2273)
90a456e 
Issue Resolved:
#2155

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
(cherry picked from commit 763b7f0)

Co-authored-by: Bandini <63824432+bandinib-amzn@users.noreply.github.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
@bandinib-amzn bandinib-amzn deleted the timeline-glyph branch September 15, 2022 20:41
@AlexRuiz7 AlexRuiz7 mentioned this pull request Sep 16, 2022
Closed
11 tasks
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
@bandinib-amzn @sipopo
Change timeline icon (opensearch-project#2162)
0685b04 
Issue Resolved:
opensearch-project#2155

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrooshalUX KrooshalUX KrooshalUX left review comments

@kgcreative kgcreative kgcreative left review comments

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@joshuarrrr joshuarrrr joshuarrrr approved these changes

@seraphjiang seraphjiang seraphjiang approved these changes

Assignees

@bandinib-amzn bandinib-amzn

Labels
backport 2.x ux / ui Improvements or additions to user experience, flows, components, UI elements v2.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bandinib-amzn @ashwin-pc @kavilla @seraphjiang @joshuarrrr @kgcreative @KrooshalUX