Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [D&D] Save index pattern using proper saved object structure #2271

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 428e832 from #2218

@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner September 6, 2022 17:47
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (2.x@71c7374). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 428e832 differs from pull request most recent head acb92f0. Consider uploading reports for the commit acb92f0 to get more accurate results

@@          Coverage Diff           @@
##             2.x    #2271   +/-   ##
======================================
  Coverage       ?   66.78%           
======================================
  Files          ?     3133           
  Lines          ?    60079           
  Branches       ?     9153           
======================================
  Hits           ?    40121           
  Misses         ?    17767           
  Partials       ?     2191           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

kavilla
kavilla previously approved these changes Sep 6, 2022
* Save index pattern as a proper saved object relationship, previously it is only saved as an id in the visualizationState.

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* remove index id from visualization when saving & add comments

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* add migration for existing wizard

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* add migration unit test

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* change wizard doc version to 2; change migration version to 2.3.0

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit 428e832)
@kavilla kavilla merged commit c477382 into 2.x Sep 7, 2022
@github-actions github-actions bot deleted the backport/backport-2218-to-2.x branch September 7, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants