Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 2402 | remove extra typo from readme. #2403

Merged
merged 1 commit into from
Sep 22, 2022
Merged

fix 2402 | remove extra typo from readme. #2403

merged 1 commit into from
Sep 22, 2022

Conversation

sagar-rout
Copy link
Contributor

@sagar-rout sagar-rout commented Sep 22, 2022 •
edited by kavilla
Loading

Description

It removes the typo in the README.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@sagar-rout sagar-rout requested a review from a team as a code owner September 22, 2022 09:04
@sagar-rout sagar-rout mentioned this pull request Sep 22, 2022
Closed
@ashwin-pc
Copy link
Member

@sagar-rout Thanks for the PR! Can you add a sign-off to the commit too?

@kavilla kavilla linked an issue Sep 22, 2022 that may be closed by this pull request
[BUG] Typo in the README #2402
Closed
@sagar-rout
fix 2402 | remove extra typo from readme.
e21c529 
Signed-off-by: Sagar Rout <sagar_rout@hotmail.com>
@sagar-rout sagar-rout force-pushed the fix/#2402-fix-typo-in-readme branch from 02ea9c5 to e21c529 Compare September 22, 2022 10:13
@sagar-rout
Copy link
Contributor Author

Thanks, I updated the git commit signoff. Sorry, I just updated the change using codespaces so signoff is missing.

@kavilla kavilla added bug Something isn't working docs Improvements or additions to documentation backport 2.x labels Sep 22, 2022
kavilla
kavilla approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thank you so much!

@kavilla kavilla merged commit 1dcf6fd into opensearch-project:main Sep 22, 2022
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 22, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 22, 2022
@sagar-rout @github-actions
Remove extra typo from README. (#2403)
69526bf 
Removing extra `to` within the README.

Issue:

#2402

Signed-off-by: Sagar Rout <sagar_rout@hotmail.com>
(cherry picked from commit 1dcf6fd)
ananzh pushed a commit that referenced this pull request Sep 22, 2022
@opensearch-trigger-bot @sagar-rout
Remove extra typo from README. (#2403) (#2404)
ee4e304 
Removing extra `to` within the README.

Issue:

#2402

Signed-off-by: Sagar Rout <sagar_rout@hotmail.com>
(cherry picked from commit 1dcf6fd)

Co-authored-by: Sagar Rout <sagar_rout@hotmail.com>
@seraphjiang seraphjiang mentioned this pull request Sep 30, 2022
Merged
1 task
@AMoo-Miki AMoo-Miki added the v2.4.0 'Issues and PRs related to version v2.4.0' label Nov 5, 2022
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
@sagar-rout @sipopo
Remove extra typo from README. (opensearch-project#2403)
d1247c5 
Removing extra `to` within the README.

Issue:

opensearch-project#2402

Signed-off-by: Sagar Rout <sagar_rout@hotmail.com>
Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@kavilla kavilla kavilla approved these changes

Assignees
No one assigned
Labels
backport 2.x bug Something isn't working docs Improvements or additions to documentation v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Typo in the README
4 participants
@sagar-rout @ashwin-pc @kavilla @AMoo-Miki