-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 1.x] Resolves ansi-regex to v5.0.1 #2425
Conversation
Signed-off-by: Zilong Xia <zilongx@amazon.com>
@ZilongX Did the backport automation fail here? Or did we just never label it appropriately for backport? |
To be honest, I think it was intentionally not added since plugins might use this package but I dont think the resolutions section should be picked up by the build process we should check. |
@joshuarrrr, yes the previous fix PR was not labeled for backporting somehow (#1320), since we're still actively consuming v1.3 which makes this CVE fix still needed in 1.x |
@kavilla , just did a quick search across the whole
Given there are no breaking changes introduced in from v2.1.1 to v5.0.1, the potential plugin consumption of |
@joshuarrrr @kavilla Trying to catch up the release training for 1.3.6 (code freeze EOD tomorrow), appreciating a quick review / feedback on this one (。•ᴗ-)_ |
Curious to learn, where can verify no breaking changes introduced during these versions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't break the build because the resolutions does not get checked in the dependency checking mechanism.
@kristenTian My understanding is that one way to manually verify is:
|
Signed-off-by: Zilong Xia <zilongx@amazon.com> Signed-off-by: Zilong Xia <zilongx@amazon.com> (cherry picked from commit a98792a)
Signed-off-by: Zilong Xia zilongx@amazon.com
Description
ansi-regex
to5.0.1
2.0.0
(Resolvesansi-regex
to v5.0.1 #1320) to1.x
Issues Resolved
Resolves #1084
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr