Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VisBuilder] Change classname prefix wiz to vb #2581

Merged
merged 1 commit into from
Oct 17, 2022
Merged

[VisBuilder] Change classname prefix wiz to vb #2581

merged 1 commit into from
Oct 17, 2022

Conversation

abbyhu2000
Copy link
Member

@abbyhu2000 abbyhu2000 commented Oct 14, 2022 •
edited
Loading

Signed-off-by: abbyhu2000 abigailhu2000@gmail.com

Description

Replace class name prefixes wiz with vb for visualization builder.

Issues Resolved

solve bullet three of #1706

Screen Shot 2022-10-17 at 11 22 12 AM

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@abbyhu2000 abbyhu2000 added vis builder v2.4.0 'Issues and PRs related to version v2.4.0' labels Oct 14, 2022
@abbyhu2000 abbyhu2000 self-assigned this Oct 14, 2022
@abbyhu2000
Change classname prefix wiz to vb
c74552b 
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
@abbyhu2000 abbyhu2000 force-pushed the replace_wiz_classname branch from c3dec8e to c74552b Compare October 14, 2022 23:28
@abbyhu2000 abbyhu2000 marked this pull request as ready for review October 14, 2022 23:29
@abbyhu2000 abbyhu2000 requested a review from a team as a code owner October 14, 2022 23:29
ashwin-pc
ashwin-pc approved these changes Oct 15, 2022
View reviewed changes
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you also add a screenshot of the page to the PR too?

ananzh
ananzh approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Abby.

@abbyhu2000 abbyhu2000 merged commit db43437 into opensearch-project:main Oct 17, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2581-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 db4343777c1129cc9c3d12b8670b4f251f9acadd
# Push it to GitHub
git push --set-upstream origin backport/backport-2581-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2581-to-2.x.

abbyhu2000 added a commit to abbyhu2000/OpenSearch-Dashboards that referenced this pull request Oct 17, 2022
@abbyhu2000
Change classname prefix wiz to vb (opensearch-project#2581)
c27418d 
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
@abbyhu2000 abbyhu2000 mentioned this pull request Oct 17, 2022
Merged
abbyhu2000 added a commit that referenced this pull request Oct 18, 2022
@abbyhu2000
Change classname prefix wiz to vb (#2581) (#2588)
72684e7 
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
abbyhu2000 added a commit to abbyhu2000/OpenSearch-Dashboards that referenced this pull request Nov 3, 2022
@abbyhu2000
Change classname prefix wiz to vb (opensearch-project#2581)
34d6b0b 
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
@abbyhu2000 abbyhu2000 mentioned this pull request Nov 3, 2022
Merged
8 tasks
ananzh pushed a commit that referenced this pull request Nov 3, 2022
@abbyhu2000
[Backport 2.4] [Vis Builder] Remaning vis builder rename backport 2.4 (…
106c3ed 
…#2770)

* Change classname prefix wiz to vb (#2581)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Change wizard to vis_builder in file names and paths (#2587)

Change all wizard reference in file names and paths to vis_builder

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Rename wizard to visBuilder in class name, type name and function name (#2639)

Rname wizard to visBuilder

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Vis Builder] Rename wizard on save modal and visualization table (#2645)

* Rename wizard on save modal and visualization table

Change the wizard reference in save modal title, toggle and visualization table

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Save visualization on save modal, VisBuilder for chart type

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* No experimental flag

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Change save object type, wizard id and name to visBuilder (#2673)

* Change save object type, wizard ID and Name to visBuilder

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Rename wizard in functional tests

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Finalize plugin-id and plugin-name and saved-object-type

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Change official name to VisBuilder

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Delete migration

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Fix functional test

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Update snapshot

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
@abbyhu2000 @sipopo
Change classname prefix wiz to vb (opensearch-project#2581)
ca2d031 
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh approved these changes

@ashwin-pc ashwin-pc ashwin-pc approved these changes

Assignees

@abbyhu2000 abbyhu2000

Labels
backport 2.x rename v2.4.0 'Issues and PRs related to version v2.4.0' vis builder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abbyhu2000 @ashwin-pc @ananzh @AMoo-Miki @kavilla