Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last Updated Timestamp for visbuilder savedobject is getting Generated #2628

Merged

Conversation

AbhishekReddy1127
Copy link
Contributor

@AbhishekReddy1127 AbhishekReddy1127 commented Oct 19, 2022

Signed-off-by: AbhishekReddy1127 nallamsa@amazon.com

Description

The Savedobjects for the VisBuilder are generating the last updated timestamp
ScreenShot:
Screen Shot 2022-10-19 at 2 42 09 PM

Issues Resolved

#2463

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@AbhishekReddy1127 AbhishekReddy1127 marked this pull request as ready for review October 20, 2022 00:03
@AbhishekReddy1127 AbhishekReddy1127 requested a review from a team as a code owner October 20, 2022 00:03
@ashwin-pc ashwin-pc added backport 2.x v2.4.0 'Issues and PRs related to version v2.4.0' labels Oct 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2022

Codecov Report

Merging #2628 (89a0dfa) into main (76d30ec) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2628      +/-   ##
==========================================
+ Coverage   66.78%   66.79%   +0.01%     
==========================================
  Files        3207     3207              
  Lines       61175    61175              
  Branches     9329     9329              
==========================================
+ Hits        40855    40863       +8     
+ Misses      18084    18079       -5     
+ Partials     2236     2233       -3     
Impacted Files Coverage Δ
...lder/common/vis_builder_saved_object_attributes.ts 100.00% <ø> (ø)
src/plugins/vis_builder/public/plugin.ts 27.58% <0.00%> (ø)
...ations/public/vis_types/vis_type_alias_registry.ts 33.33% <ø> (ø)
...ic/application/models/sense_editor/sense_editor.ts 65.77% <0.00%> (+1.77%) ⬆️
packages/osd-optimizer/src/node/cache.ts 52.77% <0.00%> (+2.77%) ⬆️
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 87.75% <0.00%> (+4.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ashwin-pc
ashwin-pc previously approved these changes Oct 21, 2022
ananzh
ananzh previously approved these changes Oct 21, 2022
Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ananzh
Copy link
Member

ananzh commented Oct 21, 2022

@AbhishekReddy1127 This is great and such a cool bean. Currently PR is outdated and you could rebase it. I could approve again after you rebase and solve the conflict.

@kavilla
Copy link
Member

kavilla commented Oct 25, 2022

@AbhishekReddy1127 would you be able to rebase this PR? Let us know if you need some assistance with that! Thanks!

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
@ashwin-pc ashwin-pc merged commit a16fe40 into opensearch-project:main Oct 26, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2628-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a16fe4064257d72059307717a3e26023142d9b7a
# Push it to GitHub
git push --set-upstream origin backport/backport-2628-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2628-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 2, 2022
…ed (#2628)

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
(cherry picked from commit a16fe40)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 2, 2022
…ed (#2628)

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
(cherry picked from commit a16fe40)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
kristenTian pushed a commit that referenced this pull request Nov 2, 2022
…ed (#2628) (#2742)

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
(cherry picked from commit a16fe40)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kristenTian pushed a commit that referenced this pull request Nov 2, 2022
…ed (#2628) (#2743)

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
(cherry picked from commit a16fe40)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
…ed (opensearch-project#2628)

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Arpit-Bandejiya pushed a commit to Arpit-Bandejiya/OpenSearch-Dashboards that referenced this pull request Jan 13, 2023
…ed (opensearch-project#2628)

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x v2.4.0 'Issues and PRs related to version v2.4.0' vis builder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants