Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.4][Chore] Refactor and improve Discover field summaries #2778

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Nov 3, 2022

  • [Chore] Refactor and improve field summaries
  • Convert to typescript
  • Fix types
  • Add tests
  • Groups are now naturally sorted by key, which requires selecting a different date filter
  • [Chore] Add changelog entry
  • [Chore] Refactor columns passing, fix bugs
  • pass columns explicitly as props
  • fix branding in core mocks
  • fix toBeUndefined() usage in tests
  • remove leftover comment
  • fix test subject
  • condense types

Backport PR:
#2391

Signed-off-by: Josh Romero rmerqg@amazon.com

Signed-off-by: Josh Romero rmerqg@amazon.com
(cherry picked from commit b53d4d8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

* [Chore] Refactor and improve field summaries
* Convert to typescript
* Fix types
* Add tests
* Groups are now naturally sorted by key, which requires selecting a different date filter
* [Chore] Add changelog entry
* [Chore] Refactor columns passing, fix bugs
* pass columns explicitly as props
* fix branding in core mocks
* fix `toBeUndefined()` usage in tests
* remove leftover comment
* fix test subject
* condense types

Backport PR:
opensearch-project#2391

Signed-off-by: Josh Romero <rmerqg@amazon.com>

Signed-off-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit b53d4d8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ananzh ananzh requested a review from a team as a code owner November 3, 2022 22:22
@ananzh ananzh added the autocut Skip the changelog verification check on backports label Nov 3, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2778 (b8ffd35) into 2.4 (106c3ed) will increase coverage by 0.01%.
The diff coverage is 93.61%.

@@            Coverage Diff             @@
##              2.4    #2778      +/-   ##
==========================================
+ Coverage   66.73%   66.74%   +0.01%     
==========================================
  Files        3209     3209              
  Lines       61251    61255       +4     
  Branches     9359     9368       +9     
==========================================
+ Hits        40876    40887      +11     
+ Misses      18129    18123       -6     
+ Partials     2246     2245       -1     
Impacted Files Coverage Δ
src/core/public/mocks.ts 59.09% <ø> (ø)
.../application/components/sidebar/discover_field.tsx 84.37% <ø> (ø)
...ation/components/sidebar/discover_field_bucket.tsx 88.88% <ø> (+22.22%) ⬆️
.../application/components/sidebar/lib/get_details.ts 62.50% <50.00%> (+5.35%) ⬆️
...tion/components/sidebar/discover_field_details.tsx 80.00% <91.66%> (+14.78%) ⬆️
...ication/components/sidebar/lib/field_calculator.ts 96.87% <96.87%> (ø)
...pplication/components/sidebar/discover_sidebar.tsx 78.37% <100.00%> (ø)
.../components/sidebar/lib/visualize_trigger_utils.ts 52.94% <0.00%> (+11.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshuarrrr joshuarrrr merged commit a24479e into opensearch-project:2.4 Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants