Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MD] Add explicit no spellcheck on password fields #2818

Merged
merged 1 commit into from
Nov 7, 2022
Merged

[MD] Add explicit no spellcheck on password fields #2818

merged 1 commit into from
Nov 7, 2022

Conversation

kristenTian
Copy link
Contributor

Signed-off-by: Kristen Tian tyarong@amazon.com

Description

[Describe what this change achieves]

Issues Resolved

#2657

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@kristenTian kristenTian requested a review from a team as a code owner November 7, 2022 18:48
@kristenTian kristenTian added backport 2.x backport 2.4 v2.4.0 'Issues and PRs related to version v2.4.0' security fix Security fix generated by Mend labels Nov 7, 2022
joshuarrrr
joshuarrrr previously approved these changes Nov 7, 2022
View reviewed changes
@joshuarrrr
Copy link
Member

looks good. missing the changelog update.

@kristenTian kristenTian changed the title [MD] Add explicit no spell check to password fields [MD] Add explicit no spellcheck on password fields Nov 7, 2022
@kristenTian kristenTian added security feature and removed security fix Security fix generated by Mend labels Nov 7, 2022
@kavilla kavilla added the multiple datasource multiple datasource project label Nov 7, 2022
joshuarrrr
joshuarrrr previously approved these changes Nov 7, 2022
View reviewed changes
ananzh
ananzh reviewed Nov 7, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
kavilla
kavilla previously approved these changes Nov 7, 2022
View reviewed changes
@kavilla
Copy link
Member

kavilla commented Nov 7, 2022

@AMoo-Miki @ananzh, this has been approved to go into 2.4.0

@kristenTian
[MD] Add explicit no spellcheck on password fields
84fe88f 
Signed-off-by: Kristen Tian <tyarong@amazon.com>
zhongnansu
zhongnansu previously approved these changes Nov 7, 2022
View reviewed changes
@kristenTian kristenTian dismissed stale reviews from zhongnansu and kavilla via 84fe88f November 7, 2022 21:48
@kristenTian kristenTian merged commit fe4b860 into opensearch-project:main Nov 7, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 7, 2022
@github-actions
[MD] Add explicit no spellcheck on password fields (#2818)
9ba5100 
Signed-off-by: Kristen Tian <tyarong@amazon.com>

Signed-off-by: Kristen Tian <tyarong@amazon.com>
(cherry picked from commit fe4b860)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
This was referenced Nov 7, 2022
Merged
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 7, 2022
@github-actions
[MD] Add explicit no spellcheck on password fields (#2818)
e1da2c0 
Signed-off-by: Kristen Tian <tyarong@amazon.com>

Signed-off-by: Kristen Tian <tyarong@amazon.com>
(cherry picked from commit fe4b860)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
kristenTian pushed a commit that referenced this pull request Nov 8, 2022
@opensearch-trigger-bot @github-actions
[MD] Add explicit no spellcheck on password fields (#2818) (#2822)
f1069ff 
Signed-off-by: Kristen Tian <tyarong@amazon.com>

Signed-off-by: Kristen Tian <tyarong@amazon.com>
(cherry picked from commit fe4b860)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kristenTian pushed a commit that referenced this pull request Nov 8, 2022
@opensearch-trigger-bot @github-actions
[MD] Add explicit no spellcheck on password fields (#2818) (#2821)
7c97977 
Signed-off-by: Kristen Tian <tyarong@amazon.com>

Signed-off-by: Kristen Tian <tyarong@amazon.com>
(cherry picked from commit fe4b860)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AlexRuiz7 pushed a commit to wazuh/wazuh-dashboard that referenced this pull request Dec 14, 2022
@kristenTian @AlexRuiz7
[MD] Add explicit no spellcheck on password fields (opensearch-projec…
32087bf 
…t#2818)

Signed-off-by: Kristen Tian <tyarong@amazon.com>

Signed-off-by: Kristen Tian <tyarong@amazon.com>
AlexRuiz7 pushed a commit to wazuh/wazuh-dashboard that referenced this pull request Dec 14, 2022
@kristenTian @AlexRuiz7
[MD] Add explicit no spellcheck on password fields (opensearch-projec…
0b3eb61 
…t#2818)

Signed-off-by: Kristen Tian <tyarong@amazon.com>

Signed-off-by: Kristen Tian <tyarong@amazon.com>
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
@kristenTian @sipopo
[MD] Add explicit no spellcheck on password fields (opensearch-projec…
89ed89b 
…t#2818)

Signed-off-by: Kristen Tian <tyarong@amazon.com>

Signed-off-by: Kristen Tian <tyarong@amazon.com>
Signed-off-by: Sergey Osipov <sipopo@yandex.ru>
Arpit-Bandejiya pushed a commit to Arpit-Bandejiya/OpenSearch-Dashboards that referenced this pull request Jan 13, 2023
@kristenTian @Arpit-Bandejiya
[MD] Add explicit no spellcheck on password fields (opensearch-projec…
20b72cc 
…t#2818)

Signed-off-by: Kristen Tian <tyarong@amazon.com>

Signed-off-by: Kristen Tian <tyarong@amazon.com>
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
@kristenTian @sikhote
[MD] Add explicit no spellcheck on password fields (opensearch-projec…
1788714 
…t#2818)

Signed-off-by: Kristen Tian <tyarong@amazon.com>

Signed-off-by: Kristen Tian <tyarong@amazon.com>
Signed-off-by: David Sinclair <david@sinclair.tech>
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
@kristenTian @sikhote
[MD] Add explicit no spellcheck on password fields (opensearch-projec…
ea63232 
…t#2818)

Signed-off-by: Kristen Tian <tyarong@amazon.com>

Signed-off-by: Kristen Tian <tyarong@amazon.com>
Signed-off-by: David Sinclair <david@sinclair.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh left review comments

@mpabba3003 mpabba3003 mpabba3003 approved these changes

@kavilla kavilla kavilla approved these changes

@joshuarrrr joshuarrrr joshuarrrr approved these changes

@zhongnansu zhongnansu zhongnansu left review comments

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

Assignees
No one assigned
Labels
backport 2.x multiple datasource multiple datasource project security feature v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kristenTian @joshuarrrr @kavilla @zhongnansu @ananzh @mpabba3003