-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix readme URL #284
Fix readme URL #284
Conversation
Fix readme with proper instructions to clone the repo for OpenSearch-Dashboards
❌ DCO Check Failed 2766fab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jkowall for the change. LGTM !!
Looks good just the commit needs a sign-off
|
Signed-off-by: Jonah Kowall <jkowall@kowall.net>
Thanks, I hope I did it right. I'm used to CLA not DCO :) |
❌ DCO Check Failed 4ff1201 |
Yes perfect! The only thing is it is the bot is checking each commit to be signed off, so for it to pass the automated checks, you should be able to do an interactive rebase to squash the commits so it's one big commit that includes the sign off with the first commit or amend the first commit to also have the sign off message. The bot basically only check if the commit description has Let me know if I should clarify anything, and thank you for the help! |
* Add workspace create page Signed-off-by: Lin Wang <wonglam@amazon.com> * Address PR comments Signed-off-by: Lin Wang <wonglam@amazon.com> * Add more comments Signed-off-by: Lin Wang <wonglam@amazon.com> * Add example for dependencies field in App Signed-off-by: Lin Wang <wonglam@amazon.com> * Separate workspace feature selector Signed-off-by: Lin Wang <wonglam@amazon.com> * Correct example for dependencies Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove unclear icon and defaultVISTheme input Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove unclear dependencies feature Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove states and fix onChange fired after mount Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com>
* Add workspace create page Signed-off-by: Lin Wang <wonglam@amazon.com> * Address PR comments Signed-off-by: Lin Wang <wonglam@amazon.com> * Add more comments Signed-off-by: Lin Wang <wonglam@amazon.com> * Add example for dependencies field in App Signed-off-by: Lin Wang <wonglam@amazon.com> * Separate workspace feature selector Signed-off-by: Lin Wang <wonglam@amazon.com> * Correct example for dependencies Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove unclear icon and defaultVISTheme input Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove unclear dependencies feature Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove states and fix onChange fired after mount Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com>
Fix readme with proper instructions to clone the repo for OpenSearch-Dashboards
Description
Fixes the URL for this repo
Issues Resolved
No issue opened yet