Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version on 2.x branch to 2.5.0 #2884

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Nov 16, 2022

Signed-off-by: Zelin Hao zelinhao@amazon.com

Description

Bump version on 2.x branch to 2.5.0

Issues Resolved

Part of post release activities as we just launched the 2.4.0 release.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
@kavilla kavilla added v2.5.0 'Issues and PRs related to version v2.5.0' versioning labels Nov 16, 2022
@zhongnansu
Copy link
Member

From OSS oncall: CI failed. can you check? If a re-run is needed and you don't have permission to trigger, let me know
@zelinh

@kavilla
Copy link
Member

kavilla commented Nov 17, 2022

From OSS oncall: CI failed. can you check? If a re-run is needed and you don't have permission to trigger, let me know @zelinh

It usually means that 2.5 isn't ready but right there is a chicken and egg problem I guess because part of the 2.5 stuff is that they won't trigger an OpenSearch build until OpenSearch and OpenSearch Dashboards have been bumped. But the CI would depend on 2.5 OpenSearch snapshot being built. So historically we have just merged this version bumps with the CI failing.

@codecov-commenter
Copy link

Codecov Report

Merging #2884 (d1dfb7f) into 2.x (5926313) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x    #2884   +/-   ##
=======================================
  Coverage   66.67%   66.68%           
=======================================
  Files        3219     3219           
  Lines       61445    61445           
  Branches     9417     9417           
=======================================
+ Hits        40968    40972    +4     
+ Misses      18231    18228    -3     
+ Partials     2246     2245    -1     
Impacted Files Coverage Δ
...ic/application/models/sense_editor/sense_editor.ts 64.88% <0.00%> (ø)
packages/osd-optimizer/src/node/cache.ts 52.63% <0.00%> (+2.63%) ⬆️
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 87.75% <0.00%> (+4.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zelinh
Copy link
Member Author

zelinh commented Nov 17, 2022

From OSS oncall: CI failed. can you check? If a re-run is needed and you don't have permission to trigger, let me know @zelinh

It usually means that 2.5 isn't ready but right there is a chicken and egg problem I guess because part of the 2.5 stuff is that they won't trigger an OpenSearch build until OpenSearch and OpenSearch Dashboards have been bumped. But the CI would depend on 2.5 OpenSearch snapshot being built. So historically we have just merged this version bumps with the CI failing.

Right. We won't be able to trigger the build for 2.5.0 until version gets incremented and I think without the build the bwc tests couldn't pass. We now only have the min artifacts for OpenSearch instead of Dashboards.

So do I need to add anything to the CHANGELOG or you would take care of it? Thanks. @kavilla

@kavilla kavilla merged commit 0d7ec27 into opensearch-project:2.x Nov 17, 2022
@ananzh ananzh mentioned this pull request Feb 22, 2023
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.5.0 'Issues and PRs related to version v2.5.0' versioning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants