Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.x] Fixes misleading embeddable plugin error message #3152

Merged
merged 3 commits into from
Jan 25, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport bd52024 from #3043.

Resolves #1479
Resolves #3083

Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit bd52024)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@kavilla kavilla added the autocut Skip the changelog verification check on backports label Jan 18, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3152 (54ffc93) into 1.x (54ffc93) will not change coverage.
The diff coverage is n/a.

❗ Current head 54ffc93 differs from pull request most recent head f9df299. Consider uploading reports for the commit f9df299 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##              1.x    #3152   +/-   ##
=======================================
  Coverage   67.49%   67.49%           
=======================================
  Files        3044     3044           
  Lines       58696    58696           
  Branches     8902     8902           
=======================================
  Hits        39615    39615           
  Misses      16932    16932           
  Partials     2149     2149           
Flag Coverage Δ
Linux 67.44% <0.00%> (ø)
Windows 67.44% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ananzh ananzh merged commit 1e5f345 into 1.x Jan 25, 2023
@github-actions github-actions bot deleted the backport/backport-3043-to-1.x branch January 25, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports v1.3.8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants