[CI][Windows] increase timeout to check run_worker process exit #3185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increasing the timeout if platform is on Windows to 10 seconds from 5 seconds. Origin: https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/3850790218/jobs/6561333017 In this run, the error: ``` ERROR UNHANDLED ERROR ERROR Error: process did not automatically exit within 5 seconds, forcing exit at Timeout._onTimeout (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\packages\osd-optimizer\src\worker\run_worker.ts:81:9) ``` Occurred for Windows when running: ``` node scripts/build_opensearch_dashboards_platform_plugins --no-examples --workers 10 ``` The process appears not to end in the expected time given for the Windows CI and based on known performance issues, this increases the timeout for windows to allow for the Windows processes to attempt to naturally end within 10 seconds rather than 5 seconds. Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
force-pushed
the
avillk/inc-timeout-for-run-worker
branch
from
3ff058c to
0929df1
Compare
|
Do we have evidence of this happening in both |
Codecov Report
@@ Coverage Diff @@
## main #3185 +/- ##
=======================================
Coverage 66.53% 66.53%
=======================================
Files 3200 3200
Lines 61249 61249
Branches 9426 9426
=======================================
Hits 40753 40753
Misses 18247 18247
Partials 2249 2249
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
it might be because the retry is on main only so we dont see this happening often in the CI for main |
8 tasks
|
Closed in favor of: #3193 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increasing the timeout if platform is on Windows to 10 seconds from 5 seconds.
Origin:
https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/3850790218/jobs/6561333017
In this run, the error:
Occurred for Windows when running:
The process appears not to end in the expected time given for the Windows CI and based on known performance issues, this increases the timeout for windows to allow for the Windows processes to attempt to naturally end within 10 seconds rather than 5 seconds.
Signed-off-by: Kawika Avilla kavilla414@gmail.com
Issues Resolved
n/a
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr